Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 23602002: Fix handling of unset AppConfig model properties. (Closed)

Created:
7 years, 3 months ago by Mattias Nissler (ping if slow)
Modified:
7 years, 3 months ago
Reviewers:
agable
CC:
chromium-reviews
Base URL:
https://git.chromium.org/git/chromium/tools/reviewbot.git@master
Visibility:
Public.

Description

Fix handling of unset AppConfig model properties. BUG=None R=agable@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219790

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M app_config.py View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Mattias Nissler (ping if slow)
7 years, 3 months ago (2013-08-27 14:18:42 UTC) #1
agable
https://chromiumcodereview-hr.appspot.com/23602002/diff/1/app_config.py File app_config.py (right): https://chromiumcodereview-hr.appspot.com/23602002/diff/1/app_config.py#newcode64 app_config.py:64: (field, field, cgi.escape(getattr(app_config, field) or ''))) can simply use ...
7 years, 3 months ago (2013-08-27 14:35:15 UTC) #2
Mattias Nissler (ping if slow)
https://chromiumcodereview-hr.appspot.com/23602002/diff/1/app_config.py File app_config.py (right): https://chromiumcodereview-hr.appspot.com/23602002/diff/1/app_config.py#newcode64 app_config.py:64: (field, field, cgi.escape(getattr(app_config, field) or ''))) On 2013/08/27 14:35:15, ...
7 years, 3 months ago (2013-08-27 14:40:09 UTC) #3
agable
On 2013/08/27 14:40:09, Mattias Nissler wrote: > https://chromiumcodereview-hr.appspot.com/23602002/diff/1/app_config.py > File app_config.py (right): > > https://chromiumcodereview-hr.appspot.com/23602002/diff/1/app_config.py#newcode64 ...
7 years, 3 months ago (2013-08-27 14:47:02 UTC) #4
Mattias Nissler (ping if slow)
7 years, 3 months ago (2013-08-27 14:51:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r219790 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698