test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc - Issue 2360193003: Revert of [Interpreter] Optimize BytecodeArrayBuilder and BytecodeArrayWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc

Issue 2360193003: Revert of [Interpreter] Optimize BytecodeArrayBuilder and BytecodeArrayWriter. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/unittests/interpreter/bytecode-array-writer-unittest.cc ('k') | test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc b/test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc

index 4cb5e69f4e19b46cccebeaf316dd3c30112ddb63..2b2171bc788106745cc060b980b6e34ef3e56c6a 100644

--- a/test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc

+++ b/test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc

@@ -16,8 +16,7 @@

class BytecodeDeadCodeOptimizerTest : public BytecodePipelineStage,

public TestWithIsolateAndZone {

public:

- BytecodeDeadCodeOptimizerTest()

- : dead_code_optimizer_(this), last_written_(Bytecode::kIllegal) {}

+ BytecodeDeadCodeOptimizerTest() : dead_code_optimizer_(this) {}

~BytecodeDeadCodeOptimizerTest() override {}

void Write(BytecodeNode* node) override {

@@ -57,7 +56,7 @@

CHECK_EQ(add, last_written());

BytecodeLabel target;

- BytecodeNode jump(Bytecode::kJump, 0, nullptr);

+ BytecodeNode jump(Bytecode::kJump, 0);

optimizer()->WriteJump(&jump, &target);

CHECK_EQ(write_count(), 2);

CHECK_EQ(jump, last_written());

@@ -101,7 +100,7 @@

TEST_F(BytecodeDeadCodeOptimizerTest, DeadCodeAfterJumpEliminated) {

BytecodeLabel target;

- BytecodeNode jump(Bytecode::kJump, 0, nullptr);

+ BytecodeNode jump(Bytecode::kJump, 0);

optimizer()->WriteJump(&jump, &target);

CHECK_EQ(write_count(), 1);

CHECK_EQ(jump, last_written());

@@ -119,7 +118,7 @@

CHECK_EQ(ret, last_written());

BytecodeLabel target;

- BytecodeNode jump(Bytecode::kJumpIfTrue, 0, nullptr);

+ BytecodeNode jump(Bytecode::kJumpIfTrue, 0);

optimizer()->WriteJump(&jump, &target);

CHECK_EQ(write_count(), 1);

CHECK_EQ(ret, last_written());