[Android] More @RetryOnFailure in chrome_public_test_apk.

[Android] More @RetryOnFailure in chrome_public_test_apk.

Specifically, for:
 - ChromeBackgroundServiceTest.*
 - all tests deriving from PaymentRequestTestBase

BUG=619055
TBR=tedchoc@chromium.org,boliu@chromium.org

Committed: https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6
Cr-Commit-Position: refs/heads/master@{#420265}

[jbudorick, 2016-09-22 04:54:56]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-09-22 04:55:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2016-09-22 04:59:32]

reasoning..?

[jbudorick, 2016-09-22 05:02:41]

On 2016/09/22 04:59:32, boliu wrote:
> reasoning..?

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
/
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...

[jbudorick, 2016-09-22 05:03:24]

On 2016/09/22 05:02:41, jbudorick wrote:
> On 2016/09/22 04:59:32, boliu wrote:
> > reasoning..?
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
> /
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...

also comment chain starting at
https://bugs.chromium.org/p/chromium/issues/detail?id=637448#c13

[boliu, 2016-09-22 05:09:53]

is that enough evidence to retry *all* payment tests? or do you think the
particular failure will affect all those tests, just a few happened to have hit
the problem

[commit-bot: I haz the power, 2016-09-22 05:23:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-22 05:25:08]

Description was changed from

==========
[Android] More @RetryOnFailure in chrome_public_test_apk.

Specifically, for:
 - ChromeBackgroundServiceTest.*
 - all tests deriving from PaymentRequestTestBase

BUG=619055
TBR=tedchoc@chromium.org,boliu@chromium.org
==========

to

==========
[Android] More @RetryOnFailure in chrome_public_test_apk.

Specifically, for:
 - ChromeBackgroundServiceTest.*
 - all tests deriving from PaymentRequestTestBase

BUG=619055
TBR=tedchoc@chromium.org,boliu@chromium.org

Committed: https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6
Cr-Commit-Position: refs/heads/master@{#420265}
==========

[commit-bot: I haz the power, 2016-09-22 05:25:09]

Patchset 1 (id:??) landed as
https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6
Cr-Commit-Position: refs/heads/master@{#420265}

[boliu, 2016-09-22 05:26:35]

I also kinda don't like putting the annotation on the base class. The shaming
aspect of the annotation no longer works, and any new payment test just silently
gets retried..

[jbudorick, 2016-09-22 14:04:26]

On 2016/09/22 05:09:53, boliu wrote:
> is that enough evidence to retry *all* payment tests? or do you think the
> particular failure will affect all those tests, just a few happened to have
hit
> the problem

 - The failure mode (failure to load a file URL) looked specific to everything
that uses PaymentRequestTestBase.mTestFilePath:
https://codesearch.chromium.org/chromium/src/chrome/android/javatests/src/org...
 - There were *a lot* of Payment* tests that were already marked as
@RetryOnFailure.

[jbudorick, 2016-09-22 14:04:52]

On 2016/09/22 05:26:35, boliu wrote:
> I also kinda don't like putting the annotation on the base class. The shaming
> aspect of the annotation no longer works, and any new payment test just
silently
> gets retried..

I don't think it'd work anyway.

[boliu, 2016-09-22 14:06:14]

On 2016/09/22 14:04:52, jbudorick wrote:
> On 2016/09/22 05:26:35, boliu wrote:
> > I also kinda don't like putting the annotation on the base class. The
shaming
> > aspect of the annotation no longer works, and any new payment test just
> silently
> > gets retried..
> 
> I don't think it'd work anyway.

Maybe we should ban adding the annotation to the entire class then.