Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2360183002: [Android] More @RetryOnFailure in chrome_public_test_apk. (Closed)

Created:
4 years, 3 months ago by jbudorick
Modified:
4 years, 3 months ago
Reviewers:
Ted C, boliu
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] More @RetryOnFailure in chrome_public_test_apk. Specifically, for: - ChromeBackgroundServiceTest.* - all tests deriving from PaymentRequestTestBase BUG=619055 TBR=tedchoc@chromium.org,boliu@chromium.org Committed: https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6 Cr-Commit-Position: refs/heads/master@{#420265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -82 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestAbortTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFailCompleteTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java View 8 chunks +0 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteEmailTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteServerCardTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java View 9 chunks +0 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultipleContactDetailsTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java View 15 chunks +0 lines, -15 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndCardsTest.java View 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneAndFreeShippingTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRemoveBillingAddressTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServerCardTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTabTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestUseStatsTest.java View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
jbudorick
4 years, 3 months ago (2016-09-22 04:53:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360183002/1
4 years, 3 months ago (2016-09-22 04:55:09 UTC) #3
boliu
reasoning..?
4 years, 3 months ago (2016-09-22 04:59:32 UTC) #4
jbudorick
On 2016/09/22 04:59:32, boliu wrote: > reasoning..? http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20(with%20patch) / https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng?numbuilds=200
4 years, 3 months ago (2016-09-22 05:02:41 UTC) #5
jbudorick
On 2016/09/22 05:02:41, jbudorick wrote: > On 2016/09/22 04:59:32, boliu wrote: > > reasoning..? > ...
4 years, 3 months ago (2016-09-22 05:03:24 UTC) #6
boliu
is that enough evidence to retry *all* payment tests? or do you think the particular ...
4 years, 3 months ago (2016-09-22 05:09:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 05:23:04 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/48b0d3beb3670d7381b8b66aa7ac47433170ffb6 Cr-Commit-Position: refs/heads/master@{#420265}
4 years, 3 months ago (2016-09-22 05:25:09 UTC) #10
boliu
I also kinda don't like putting the annotation on the base class. The shaming aspect ...
4 years, 3 months ago (2016-09-22 05:26:35 UTC) #11
jbudorick
On 2016/09/22 05:09:53, boliu wrote: > is that enough evidence to retry *all* payment tests? ...
4 years, 3 months ago (2016-09-22 14:04:26 UTC) #12
jbudorick
On 2016/09/22 05:26:35, boliu wrote: > I also kinda don't like putting the annotation on ...
4 years, 3 months ago (2016-09-22 14:04:52 UTC) #13
boliu
4 years, 3 months ago (2016-09-22 14:06:14 UTC) #14
Message was sent while issue was closed.
On 2016/09/22 14:04:52, jbudorick wrote:
> On 2016/09/22 05:26:35, boliu wrote:
> > I also kinda don't like putting the annotation on the base class. The
shaming
> > aspect of the annotation no longer works, and any new payment test just
> silently
> > gets retried..
> 
> I don't think it'd work anyway.

Maybe we should ban adding the annotation to the entire class then.

Powered by Google App Engine
This is Rietveld 408576698