Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2360173002: Use ChannelMojo in ppapi_unittests. (Closed)

Created:
4 years, 3 months ago by Sam McNally
Modified:
4 years, 3 months ago
Reviewers:
raymes, tibell
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ChannelMojo in ppapi_unittests. BUG=604282 Committed: https://crrev.com/69b4ba0e1e0fd1b99f9b0b876b2831cc08a9779b Cr-Commit-Position: refs/heads/master@{#420263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M ppapi/proxy/ppapi_proxy_test.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Sam McNally
4 years, 3 months ago (2016-09-22 03:45:23 UTC) #4
raymes
+tibell to review Happy to rubberstamp if it looks ok to him
4 years, 3 months ago (2016-09-22 03:51:39 UTC) #6
tibell
lgtm
4 years, 3 months ago (2016-09-22 04:08:43 UTC) #7
raymes
lgtm
4 years, 3 months ago (2016-09-22 04:13:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360173002/1
4 years, 3 months ago (2016-09-22 05:05:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 05:10:38 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 05:12:11 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69b4ba0e1e0fd1b99f9b0b876b2831cc08a9779b
Cr-Commit-Position: refs/heads/master@{#420263}

Powered by Google App Engine
This is Rietveld 408576698