mash: Add SystemTrayClient interface, use to show date settings

ash/mus/system_tray_delegate_mus.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/mus/system_tray_delegate_mus.h"
 
 #include "ash/common/system/tray/system_tray_notifier.h"
 #include "ash/common/wm_shell.h"
 #include "base/i18n/time_formatting.h"
 #include "base/logging.h"
@@ skipping 18 matching lines @@
 
 // static
 SystemTrayDelegateMus* SystemTrayDelegateMus::Get() {
   return g_instance;
 }
 
 base::HourClockType SystemTrayDelegateMus::GetHourClockType() const {
   return hour_clock_type_;
 }
 
+void SystemTrayDelegateMus::ShowDateSettings() {
+  system_tray_client_->ShowDateSettings();

[James Cook, 2016/09/22 23:19:18]

Is there a naming convention for these interfaceptr member variables so that the
reader knows this is an IPC and not just a regular function call?

I previously just called it client_, but that seemed too vague.

[sky, 2016/09/23 16:42:26]

How do you know SetClient() has been called by the time you get here?

[sky, 2016/09/23 16:42:26]

'client_' is actually used a fair amount. And no, there isn't a naming
convention that conveys the IPC call.

+}
+
+void SystemTrayDelegateMus::SetClient(
+    mojom::SystemTrayClientPtr system_tray_client) {
+  DCHECK(system_tray_client);
+  DCHECK(!system_tray_client_);
+  system_tray_client_ = std::move(system_tray_client);
+  // No special client connection error handling.

[James Cook, 2016/09/22 23:19:18]

Not sure if I need set_connection_error_handler() here.

[sky, 2016/09/23 16:42:25]

It's only necessary if you want to take action if the client is destroyed. I
think the action you want to take is resetting special_tray_client_. That way if
SetClient is called again you don't DCHECK. Say for example chrome crashes then
comes up again.

+}
+
 void SystemTrayDelegateMus::SetUse24HourClock(bool use_24_hour) {
   hour_clock_type_ = use_24_hour ? base::k24HourClock : base::k12HourClock;
   WmShell::Get()->system_tray_notifier()->NotifyDateFormatChanged();
 }
 
 }  // namespace ash