Remove completeURL() call from WebSocket construction code

Remove completeURL() call from WebSocket construction code

The WebSocket constructor takes only absolute URLs. See this spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#parse-a-websocket-url's-components

This completeURL() call is not just unnecessary but converting given
data into invalid data. Also, implicit KURL to String conversion
happened on WebCore::WebSocket::connect() call caused spec violation.
That is it accepted URLs with double colons i.e. "ws:://example.com" by mistake.

BUG=322818
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171524

[Adam Rice, 2014-04-14 09:36:50]

lgtm

It looks like the error message in the SyntaxError we return if a relative URL
is passed to the constructor ("Failed to construct 'WebSocket': The URL's scheme
must be either 'ws' or 'wss'. 'http' is not allowed.") gives away the fact that
we aren't following
http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#pars...
exactly, but that is a pre-existing problem.

[Adam Rice, 2014-04-14 09:38:23]

On 2014/04/14 09:36:50, Adam Rice wrote:
> lgtm
> 
> It looks like the error message in the SyntaxError we return if a relative URL
> is passed to the constructor ("Failed to construct 'WebSocket': The URL's
scheme
> must be either 'ws' or 'wss'. 'http' is not allowed.") gives away the fact
that
> we aren't following
>
http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#pars...
> exactly, but that is a pre-existing problem.

Oh, I see that you fixed that too. Never mind.

[tyoshino (SeeGerritForStatus), 2014-04-14 09:41:25]

On 2014/04/14 09:38:23, Adam Rice wrote:
> On 2014/04/14 09:36:50, Adam Rice wrote:
> > lgtm
> > 
> > It looks like the error message in the SyntaxError we return if a relative
URL
> > is passed to the constructor ("Failed to construct 'WebSocket': The URL's
> scheme
> > must be either 'ws' or 'wss'. 'http' is not allowed.") gives away the fact
> that
> > we aren't following
> >
>
http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#pars...
> > exactly, but that is a pre-existing problem.
> 
> Oh, I see that you fixed that too. Never mind.

Exactly!

[tyoshino (SeeGerritForStatus), 2014-04-14 09:41:33]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-04-14 09:41:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/236013006/1

[commit-bot: I haz the power, 2014-04-14 10:10:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-14 10:10:10]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[tyoshino (SeeGerritForStatus), 2014-04-14 23:34:27]

Updated the virtual/stable expectation.

[tyoshino (SeeGerritForStatus), 2014-04-14 23:34:30]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-04-14 23:34:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/236013006/20001

[commit-bot: I haz the power, 2014-04-15 00:11:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-15 00:11:04]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[tyoshino (SeeGerritForStatus), 2014-04-15 00:19:19]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-04-15 00:19:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/236013006/20001

[commit-bot: I haz the power, 2014-04-15 00:46:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-15 00:46:59]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[tyoshino (SeeGerritForStatus), 2014-04-15 00:53:29]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-04-15 00:54:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/236013006/20001

[commit-bot: I haz the power, 2014-04-15 01:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-15 01:20:29]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[tyoshino (SeeGerritForStatus), 2014-04-15 01:41:44]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-04-15 01:42:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/236013006/20001

[commit-bot: I haz the power, 2014-04-15 02:15:30]

Change committed as 171524