chrome/browser/chromeos/customization_document_unittest.cc - Issue 236013002: Apply default wallpaper from customization manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/customization_document_unittest.cc

Issue 236013002: Apply default wallpaper from customization manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Allow customization without wallpaper. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/customization_document.cc ('K') | « chrome/browser/chromeos/customization_document.cc ('k') | chrome/browser/chromeos/customization_wallpaper_downloader.h » ('j') | chrome/browser/chromeos/login/wallpaper_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/customization_document_unittest.cc

diff --git a/chrome/browser/chromeos/customization_document_unittest.cc b/chrome/browser/chromeos/customization_document_unittest.cc

index 4eae520b385cc0d6e07bb9946fbbe8b7a505beb0..f9ca9805250603d0b288b1312a4f0e96fd1e7e2f 100644

--- a/chrome/browser/chromeos/customization_document_unittest.cc

+++ b/chrome/browser/chromeos/customization_document_unittest.cc

@@ -323,8 +323,9 @@ TEST_F(ServicesCustomizationDocumentTest, Basic) {

RunUntilIdle();

EXPECT_TRUE(doc->IsReady());

- EXPECT_EQ(doc->GetDefaultWallpaperUrl().spec(),

- "http://somedomain.com/image.png");

+ GURL wallpaper_url;

+ EXPECT_TRUE(doc->GetDefaultWallpaperUrl(&wallpaper_url));

+ EXPECT_EQ(wallpaper_url.spec(), "http://somedomain.com/image.png");

Daniel Erat 2014/04/19 14:24:08 EXPECT_EQ()'s arguments should be (expected, actua

Alexander Alekseev 2014/04/21 16:49:41 Done.

std::vector<std::string> default_apps;

EXPECT_TRUE(doc->GetDefaultApps(&default_apps));