Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2360113002: Delete unneeded test. (Closed)

Created:
4 years, 3 months ago by ghost stip (do not use)
Modified:
4 years, 3 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Delete unneeded test. Follow-up to https://codereview.chromium.org/2352393003. Note that a lot of these tests seem svn related, and can probably be deleted. I defer to to agable@ on what we can carve out here. BUG= R=agable@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f3cc160f0c5b5359fe359831b01ed09c7cc08602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
D tests/upstream.sh View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ghost stip (do not use)
ptal. happy to delete more if you think it's worth it
4 years, 3 months ago (2016-09-21 22:03:54 UTC) #1
iannucci
oh, yes, please! delete all of these! They're so broken...
4 years, 3 months ago (2016-09-21 22:09:43 UTC) #3
agable
lgtm
4 years, 3 months ago (2016-09-21 22:11:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360113002/1
4 years, 3 months ago (2016-09-21 22:11:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360113002/1
4 years, 3 months ago (2016-09-23 00:33:34 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 00:37:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/f3cc160f0c5b53...

Powered by Google App Engine
This is Rietveld 408576698