Handlify JSReceiver::SetProperty and friends.

Handlify JSReceiver::SetProperty and friends.

R=verwaest@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=16758

[Toon Verwaest, 2013-09-16 16:37:50]

lgtm with nits

https://codereview.chromium.org/23601031/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/23601031/diff/1/src/objects.cc#newcode1975
src/objects.cc:1975:
new_map->set_unused_property_fields(unused_property_fields);
Can we move these lines changing the "unused property fields" into
CopyAddFieldDescriptor?

https://codereview.chromium.org/23601031/diff/1/src/objects.cc#newcode3783
src/objects.cc:3783: handle(lookup->holder()), name, value, attributes,
kNonStrictMode,
what about getting the receiver as input directly from the caller of this
method, rather than passing it through LookupResult and always re-handlifying
it?

https://codereview.chromium.org/23601031/diff/1/src/stub-cache.cc
File src/stub-cache.cc (right):

https://codereview.chromium.org/23601031/diff/1/src/stub-cache.cc#newcode1400
src/stub-cache.cc:1400: Handle<JSObject> recv(JSObject::cast(args[0]));
CONVERT_ARG_HANDLE_CHECKED(JSObject, 0, recv);
...

[Toon Verwaest, 2013-09-16 16:38:06]

lgtm with nits

[Michael Starzinger, 2013-09-17 10:44:16]

Thanks for the review. Addressed comments. Landing.

https://codereview.chromium.org/23601031/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/23601031/diff/1/src/objects.cc#newcode1975
src/objects.cc:1975:
new_map->set_unused_property_fields(unused_property_fields);
On 2013/09/16 16:37:50, Toon Verwaest wrote:
> Can we move these lines changing the "unused property fields" into
> CopyAddFieldDescriptor?

Done.

https://codereview.chromium.org/23601031/diff/1/src/objects.cc#newcode3783
src/objects.cc:3783: handle(lookup->holder()), name, value, attributes,
kNonStrictMode,
On 2013/09/16 16:37:50, Toon Verwaest wrote:
> what about getting the receiver as input directly from the caller of this
> method, rather than passing it through LookupResult and always re-handlifying
> it?

Done.

https://codereview.chromium.org/23601031/diff/1/src/stub-cache.cc
File src/stub-cache.cc (right):

https://codereview.chromium.org/23601031/diff/1/src/stub-cache.cc#newcode1400
src/stub-cache.cc:1400: Handle<JSObject> recv(JSObject::cast(args[0]));
On 2013/09/16 16:37:50, Toon Verwaest wrote:
> CONVERT_ARG_HANDLE_CHECKED(JSObject, 0, recv);
> ...

I would love to use those macros here, but only runtime.cc has these macros
available. I propose to leave that as a followup for another cleanup.

[Michael Starzinger, 2013-09-17 11:01:57]

Committed patchset #2 manually as r16758 (presubmit successful).