Removing unnecessary context menu logic

chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextmenu;
 
 import android.app.Activity;
 import android.view.ContextMenu;
 import android.view.ContextMenu.ContextMenuInfo;
 import android.view.MenuItem;
@@ skipping 40 matching lines @@
     private void setPopulator(ContextMenuPopulator populator) {
         mPopulator = populator;
     }
 
     /**
      * Starts showing a context menu for {@code view} based on {@code params}.
      * @param contentViewCore The {@link ContentViewCore} to show the menu to.
      * @param params          The {@link ContextMenuParams} that indicate what menu items to show.
      */
     @CalledByNative
-    private boolean showContextMenu(ContentViewCore contentViewCore, ContextMenuParams params) {
+    private void showContextMenu(ContentViewCore contentViewCore, ContextMenuParams params) {
         final View view = contentViewCore.getContainerView();
 
         if (view == null
                 || view.getVisibility() != View.VISIBLE
                 || view.getParent() == null) {
-            return false;
+            return;
         }
 
         mCurrentContextMenuParams = params;
 
         view.setOnCreateContextMenuListener(this);
         if (view.showContextMenu()) {
             WebContents webContents = contentViewCore.getWebContents();
             RecordHistogram.recordBooleanHistogram(
                     "ContextMenu.Shown", webContents != null);
-            if (webContents != null) webContents.onContextMenuOpened();
-            return true;
         }
-        return false;
     }
 
     /**
      * Starts a download based on the current {@link ContextMenuParams}.
      * @param isLink Whether or not the download target is a link.
      */
     public void startContextMenuDownload(boolean isLink, boolean isDataReductionProxyEnabled) {
         if (mNativeContextMenuHelper != 0) {
             nativeOnStartDownload(mNativeContextMenuHelper, isLink, isDataReductionProxyEnabled);
         }
@@ skipping 45 matching lines @@
     @VisibleForTesting
     public ContextMenuPopulator getPopulator() {
         return mPopulator;
     }
 
     private native void nativeOnStartDownload(
             long nativeContextMenuHelper, boolean isLink, boolean isDataReductionProxyEnabled);
     private native void nativeSearchForImage(long nativeContextMenuHelper);
     private native void nativeShareImage(long nativeContextMenuHelper);
 }