Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 23601022: Add chrome/browser/resources/settings_internal to .gitignore (Closed)

Created:
7 years, 3 months ago by Daniel Erat
Modified:
7 years, 3 months ago
CC:
chromium-reviews, bbudge-google
Visibility:
Public.

Description

Add chrome/browser/resources/settings_internal to .gitignore BUG=none TBR=stip@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Daniel Erat
7 years, 3 months ago (2013-09-06 17:34:37 UTC) #1
Daniel Erat
Committed patchset #1 manually as r221730 (presubmit successful).
7 years, 3 months ago (2013-09-06 17:35:19 UTC) #2
Mike Stip (use stip instead)
Do items show up in this folder as chrome runs? What needs to be ignored ...
7 years, 3 months ago (2013-09-06 18:17:18 UTC) #3
bbudge-google
Nothing will be in this folder that isn't under version control. -Bill On Fri, Sep ...
7 years, 3 months ago (2013-09-06 18:18:20 UTC) #4
Daniel Erat
7 years, 3 months ago (2013-09-06 18:28:51 UTC) #5
Message was sent while issue was closed.
External repos pulled in by DEPS files need to be listed in .gitignore or else
they show up as untracked changes whenever Chromium developers who use git run
"git status" (in my experience).

Powered by Google App Engine
This is Rietveld 408576698