Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 23601013: cc: Invalidate framebuffer contents when clearing (Closed)

Created:
7 years, 3 months ago by Sami
Modified:
7 years, 3 months ago
Reviewers:
danakj, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

cc: Invalidate framebuffer contents when clearing When clearing the contents of a framebuffer, also invalidate/discard it if the GL implementation supports this functionality. This improves performance especially on tiling architecture GPUs since the graphics driver does not need to restore the previous contents of the framebuffer before proceeding with rendering. Note that normally we don't clear the contents of framebuffers whose contents we know we will completely re-render. This patch will still invalidate such framebuffers to let the driver know that the previous contents are not relevant. BUG=274334 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221425

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use arraysize. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M cc/output/context_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/context_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 3 chunks +18 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sami
7 years, 3 months ago (2013-09-04 18:29:12 UTC) #1
piman
LGTM+nit https://codereview.chromium.org/23601013/diff/1/cc/output/gl_renderer.cc File cc/output/gl_renderer.cc (right): https://codereview.chromium.org/23601013/diff/1/cc/output/gl_renderer.cc#newcode301 cc/output/gl_renderer.cc:301: GLenum attachments[kNumAttachments] = { nit: [] and use ...
7 years, 3 months ago (2013-09-04 19:23:01 UTC) #2
Sami
On 2013/09/04 19:23:01, piman wrote: > nit: [] and use arraysize Thanks, I knew there ...
7 years, 3 months ago (2013-09-05 12:40:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/23601013/6001
7 years, 3 months ago (2013-09-05 12:43:37 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 14:52:42 UTC) #5
Message was sent while issue was closed.
Change committed as 221425

Powered by Google App Engine
This is Rietveld 408576698