Issue 23601011: Have StyleResolver / StyleResolverState deal with Document references, not pointers

Issue 23601011: Have StyleResolver / StyleResolverState deal with Document references, not pointers (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, dglazkov, abarth-chromium

CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, gavinp+prerender_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, loislo+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have StyleResolver / StyleResolverState deal with Document references, not pointers Have StyleResolver / StyleResolverState deal with Document references, not pointers since the document can never be NULL. Using references makes it obvious to the caller. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157047

Patch Set 1 #

Patch Set 2 : Update StyleResolverState as well #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -101 lines)			Patch
M	Source/core/css/CSSToStyleMap.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/RuleSet.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/FilterOperationResolver.cpp	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View	1	11 chunks	+16 lines, -16 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.h	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1	27 chunks	+52 lines, -52 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolverState.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolverState.cpp	View	1	2 chunks	+5 lines, -11 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLLinkElement.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/scripts/templates/StyleBuilderFunctions.cpp.tmpl	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

do-not-use

On 2013/08/31 20:01:40, Christophe Dumez wrote: I updated the patch to take care of StyleResolverState ...

7 years, 3 months ago (2013-09-01 15:02:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23601011/5001

7 years, 3 months ago (2013-09-01 15:33:14 UTC) #4

Message was sent while issue was closed.

Change committed as 157047

Expand Messages | Collapse Messages