Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 23601003: Adjust app.yaml application name to match appspot instance. (Closed)

Created:
7 years, 3 months ago by Mattias Nissler (ping if slow)
Modified:
7 years, 3 months ago
Reviewers:
agable
CC:
chromium-reviews
Base URL:
https://git.chromium.org/git/chromium/tools/reviewbot.git@master
Visibility:
Public.

Description

Adjust app.yaml application name to match appspot instance. This switches the application name to chromium-reviewbot, which is the name of our appengine instance. BUG=None R=agable@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M app.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mattias Nissler (ping if slow)
7 years, 3 months ago (2013-08-27 14:18:25 UTC) #1
agable
LGTM. Will you also want to move the app's source directory to tools/chromium-reviewbot to match, ...
7 years, 3 months ago (2013-08-27 14:34:03 UTC) #2
Mattias Nissler (ping if slow)
I could, but doesn't that break the mapped git repo? I it'd be a reasonable ...
7 years, 3 months ago (2013-08-27 14:35:33 UTC) #3
agable
On 2013/08/27 14:35:33, Mattias Nissler wrote: > I could, but doesn't that break the mapped ...
7 years, 3 months ago (2013-08-27 14:37:11 UTC) #4
Mattias Nissler (ping if slow)
7 years, 3 months ago (2013-08-27 14:50:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r219789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698