Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2360083006: don't close a contour with a line if nothing's there (Closed)

Created:
4 years, 2 months ago by caryclark
Modified:
4 years, 2 months ago
Reviewers:
kjlubick
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M src/pathops/SkPathWriter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caryclark
4 years, 2 months ago (2016-09-22 18:17:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360083006/1
4 years, 2 months ago (2016-09-22 18:17:13 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 2 months ago (2016-09-22 18:17:14 UTC) #5
kjlubick
lgtm
4 years, 2 months ago (2016-09-22 18:26:02 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 19:52:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1c1060724407b3b38b2ccc2a7bbb0368222838cb

Powered by Google App Engine
This is Rietveld 408576698