Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2360083005: Re-enable TestEventInContext (Closed)

Created:
4 years, 3 months ago by chiniforooshan
Modified:
4 years, 3 months ago
CC:
fmeawad, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-enable TestEventInContext https://codereview.chromium.org/2253973003 is landed. The V8 macro can be changed accordingly now and the test can be enabled again. BUG=647986 Committed: https://crrev.com/d537582d6fa4944e9759165e23d227ea0ce79dc1 Cr-Commit-Position: refs/heads/master@{#39636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M src/tracing/trace-event.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-trace-event.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
chiniforooshan
On 2016/09/22 15:27:49, chiniforooshan wrote: > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=chiniforooshan@chromium.org changed reviewers: > + https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=jochen@chromium.org PTAL. Thanks!
4 years, 3 months ago (2016-09-22 15:28:09 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-22 15:29:15 UTC) #6
fmeawad
lgtm
4 years, 3 months ago (2016-09-22 15:55:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360083005/1
4 years, 3 months ago (2016-09-22 16:28:00 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 16:31:02 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 16:31:24 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d537582d6fa4944e9759165e23d227ea0ce79dc1
Cr-Commit-Position: refs/heads/master@{#39636}

Powered by Google App Engine
This is Rietveld 408576698