Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2360083002: Remove SVGSVGElement dependency from SVGTransformListTearOff (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SVGSVGElement dependency from SVGTransformListTearOff Rather than having the latter depend on the former for code-sharing, have them both depend on the underlying primitive (SVGTransformTearOff.) Committed: https://crrev.com/80a4cb699bd9f090d6e4918f87909e0a7b385673 Cr-Commit-Position: refs/heads/master@{#420278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformListTearOff.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformListTearOff.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformTearOff.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformTearOff.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 3 months ago (2016-09-21 22:38:30 UTC) #4
pdr.
On 2016/09/21 at 22:38:30, fs wrote: > LGTM
4 years, 3 months ago (2016-09-21 22:40:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360083002/1
4 years, 3 months ago (2016-09-22 07:57:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 08:02:11 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 08:04:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80a4cb699bd9f090d6e4918f87909e0a7b385673
Cr-Commit-Position: refs/heads/master@{#420278}

Powered by Google App Engine
This is Rietveld 408576698