extensions/browser/api/execute_code_function.cc - Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/execute_code_function.cc

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)

Patch Set: lazyboy's Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/execute_code_function.cc

diff --git a/extensions/browser/api/execute_code_function.cc b/extensions/browser/api/execute_code_function.cc

index c2175fa2649481e91fa6f58bff3c9db470b215e4..d1b1ee3a8fe0f37e5c44932ec50d2785d554cfc7 100644

--- a/extensions/browser/api/execute_code_function.cc

+++ b/extensions/browser/api/execute_code_function.cc

@@ -151,7 +151,7 @@ bool ExecuteCodeFunction::Execute(const std::string& code_string) {

match_about_blank, run_at, ScriptExecutor::ISOLATED_WORLD,

IsWebView() ? ScriptExecutor::WEB_VIEW_PROCESS

: ScriptExecutor::DEFAULT_PROCESS,

- GetWebViewSrc(), file_url_, user_gesture_,

+ GetWebViewSrc(), file_url_, user_gesture(),

has_callback() ? ScriptExecutor::JSON_SERIALIZED_RESULT

: ScriptExecutor::NO_RESULT,

base::Bind(&ExecuteCodeFunction::OnExecuteCodeFinished, this));