chrome/browser/extensions/api/autofill_private/autofill_private_api.cc - Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)

Patch Set: lazyboy's Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc ('k') | chrome/browser/extensions/api/browsing_data/browsing_data_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

diff --git a/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc b/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

index 78f8020d9e9f6f1a769616604bce29df22b5857d..91430bc95a460930fc057a82f99086afdc0d2e0e 100644

--- a/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

+++ b/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

@@ -179,7 +179,7 @@ ExtensionFunction::ResponseAction AutofillPrivateSaveAddressFunction::Run() {

autofill::PersonalDataManagerFactory::GetForProfile(

chrome_details_.GetProfile());

if (!personal_data || !personal_data->IsDataLoaded()) {

- error_ = kErrorDataUnavailable;

+ SetError(kErrorDataUnavailable);

return RespondNow(NoArguments());

}

@@ -368,7 +368,7 @@ ExtensionFunction::ResponseAction AutofillPrivateSaveCreditCardFunction::Run() {

autofill::PersonalDataManagerFactory::GetForProfile(

chrome_details_.GetProfile());

if (!personal_data || !personal_data->IsDataLoaded()) {

- error_ = kErrorDataUnavailable;

+ SetError(kErrorDataUnavailable);

return RespondNow(NoArguments());

}

@@ -427,7 +427,7 @@ ExtensionFunction::ResponseAction AutofillPrivateRemoveEntryFunction::Run() {

autofill::PersonalDataManagerFactory::GetForProfile(

chrome_details_.GetProfile());

if (!personal_data || !personal_data->IsDataLoaded()) {

- error_ = kErrorDataUnavailable;

+ SetError(kErrorDataUnavailable);

return RespondNow(NoArguments());

}

@@ -479,7 +479,7 @@ ExtensionFunction::ResponseAction AutofillPrivateMaskCreditCardFunction::Run() {

autofill::PersonalDataManagerFactory::GetForProfile(

chrome_details_.GetProfile());

if (!personal_data || !personal_data->IsDataLoaded()) {

- error_ = kErrorDataUnavailable;

+ SetError(kErrorDataUnavailable);

return RespondNow(NoArguments());

}