[Extensions] Isolate ExtensionFunction results_ and error_

chrome/browser/extensions/chrome_extension_function.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/chrome_extension_function.h"
 
 #include <utility>
 
 #include "chrome/browser/extensions/chrome_extension_function_details.h"
 #include "chrome/browser/extensions/window_controller.h"
@@ skipping 24 matching lines @@
 extensions::WindowController*
 ChromeUIThreadExtensionFunction::GetExtensionWindowController() {
   return chrome_details_.GetExtensionWindowController();
 }
 
 content::WebContents*
 ChromeUIThreadExtensionFunction::GetAssociatedWebContents() {
   return chrome_details_.GetAssociatedWebContents();
 }
 
+void ChromeUIThreadExtensionFunction::SetError(const std::string& error) {
+  error_ = error;
+}
+
+const std::string& ChromeUIThreadExtensionFunction::GetError() const {
+  return error_.empty() ? UIThreadExtensionFunction::GetError() : error_;
+}
+
 void ChromeUIThreadExtensionFunction::SendResponse(bool success) {
-  Respond(success ? ArgumentList(std::move(results_)) : Error(error_));
+  ResponseValue response;
+  if (success) {
+    response = ArgumentList(std::move(results_));
+  } else {
+    response = results_ ? ErrorWithArguments(std::move(results_), error_)
+                        : Error(error_);
+  }
+  Respond(std::move(response));
+}
+
+void ChromeUIThreadExtensionFunction::SetResult(
+    std::unique_ptr<base::Value> result) {
+  results_.reset(new base::ListValue());
+  results_->Append(std::move(result));
+}
+
+void ChromeUIThreadExtensionFunction::SetResultList(
+    std::unique_ptr<base::ListValue> results) {
+  results_ = std::move(results);
 }
 
 ChromeUIThreadExtensionFunction::~ChromeUIThreadExtensionFunction() {
 }
 
 ChromeAsyncExtensionFunction::ChromeAsyncExtensionFunction() {
 }
 
 ChromeAsyncExtensionFunction::~ChromeAsyncExtensionFunction() {}
 
 ExtensionFunction::ResponseAction ChromeAsyncExtensionFunction::Run() {
-  return RunAsync() ? RespondLater() : RespondNow(Error(error_));
+  if (RunAsync())
+    return RespondLater();
+  // TODO(devlin): Track these down and eliminate them if possible. We
+  // shouldn't return results and an error.
+  if (results_)
+    return RespondNow(ErrorWithArguments(std::move(results_), error_));
+  return RespondNow(Error(error_));
 }
 
 // static
 bool ChromeAsyncExtensionFunction::ValidationFailure(
     ChromeAsyncExtensionFunction* function) {
   return false;
 }
 
 ChromeSyncExtensionFunction::ChromeSyncExtensionFunction() {
 }
 
 ChromeSyncExtensionFunction::~ChromeSyncExtensionFunction() {}
 
 ExtensionFunction::ResponseAction ChromeSyncExtensionFunction::Run() {
-  return RespondNow(RunSync() ? ArgumentList(std::move(results_))
-                              : Error(error_));
+  if (!RunSync()) {
+    DCHECK(!results_);
+    return RespondNow(Error(error_));
+  }
+  return RespondNow(ArgumentList(std::move(results_)));
 }
 
 // static
 bool ChromeSyncExtensionFunction::ValidationFailure(
     ChromeSyncExtensionFunction* function) {
   return false;
 }