[Extensions] Isolate ExtensionFunction results_ and error_

chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/autofill_private/autofill_private_api.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/guid.h"
@@ skipping 161 matching lines @@
 
 ExtensionFunction::ResponseAction AutofillPrivateSaveAddressFunction::Run() {
   std::unique_ptr<api::autofill_private::SaveAddress::Params> parameters =
       api::autofill_private::SaveAddress::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(parameters.get());
 
   autofill::PersonalDataManager* personal_data =
       autofill::PersonalDataManagerFactory::GetForProfile(
       chrome_details_.GetProfile());
   if (!personal_data || !personal_data->IsDataLoaded()) {
-    error_ = kErrorDataUnavailable;
+    SetError(kErrorDataUnavailable);
     return RespondNow(NoArguments());
   }
 
   api::autofill_private::AddressEntry* address = &parameters->address;
 
   std::string guid = address->guid ? *address->guid : "";
   autofill::AutofillProfile profile(guid, kSettingsOrigin);
 
   // Strings from JavaScript use UTF-8 encoding. This container is used as an
   // intermediate container for functions which require UTF-16 strings.
@@ skipping 168 matching lines @@
 
 ExtensionFunction::ResponseAction AutofillPrivateSaveCreditCardFunction::Run() {
   std::unique_ptr<api::autofill_private::SaveCreditCard::Params> parameters =
       api::autofill_private::SaveCreditCard::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(parameters.get());
 
   autofill::PersonalDataManager* personal_data =
       autofill::PersonalDataManagerFactory::GetForProfile(
       chrome_details_.GetProfile());
   if (!personal_data || !personal_data->IsDataLoaded()) {
-    error_ = kErrorDataUnavailable;
+    SetError(kErrorDataUnavailable);
     return RespondNow(NoArguments());
   }
 
   api::autofill_private::CreditCardEntry* card = &parameters->card;
 
   std::string guid = card->guid ? *card->guid : "";
   autofill::CreditCard credit_card(guid, kSettingsOrigin);
 
   if (card->name) {
     credit_card.SetRawInfo(autofill::CREDIT_CARD_NAME_FULL,
@@ skipping 38 matching lines @@
 
 ExtensionFunction::ResponseAction AutofillPrivateRemoveEntryFunction::Run() {
   std::unique_ptr<api::autofill_private::RemoveEntry::Params> parameters =
       api::autofill_private::RemoveEntry::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(parameters.get());
 
   autofill::PersonalDataManager* personal_data =
       autofill::PersonalDataManagerFactory::GetForProfile(
       chrome_details_.GetProfile());
   if (!personal_data || !personal_data->IsDataLoaded()) {
-    error_ = kErrorDataUnavailable;
+    SetError(kErrorDataUnavailable);
     return RespondNow(NoArguments());
   }
 
   personal_data->RemoveByGUID(parameters->guid);
 
   return RespondNow(NoArguments());
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AutofillPrivateValidatePhoneNumbersFunction
@@ skipping 31 matching lines @@
 
 ExtensionFunction::ResponseAction AutofillPrivateMaskCreditCardFunction::Run() {
   std::unique_ptr<api::autofill_private::MaskCreditCard::Params> parameters =
       api::autofill_private::MaskCreditCard::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(parameters.get());
 
   autofill::PersonalDataManager* personal_data =
       autofill::PersonalDataManagerFactory::GetForProfile(
       chrome_details_.GetProfile());
   if (!personal_data || !personal_data->IsDataLoaded()) {
-    error_ = kErrorDataUnavailable;
+    SetError(kErrorDataUnavailable);
     return RespondNow(NoArguments());
   }
 
   personal_data->ResetFullServerCard(parameters->guid);
 
   return RespondNow(NoArguments());
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AutofillPrivateGetCreditCardListFunction
@@ skipping 15 matching lines @@
 
   autofill_util::CreditCardEntryList credit_card_list =
       autofill_util::GenerateCreditCardList(*personal_data);
 
   return RespondNow(
       ArgumentList(api::autofill_private::GetCreditCardList::Results::Create(
           credit_card_list)));
 }
 
 }  // namespace extensions