Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 236003002: Revert 263352 "Introduce RenderFrameProxyHost object and use it ..." (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 263352 "Introduce RenderFrameProxyHost object and use it ..." Leaks: Linux LSan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/1508 E.g.: Indirect leak of 1544 byte(s) in 1 object(s) allocated from: #0 0x4fc78b in operator new(unsigned long) /usr/local/google/home/thakis/src/chrome/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x232ebeb in allocate /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/new_allocator.h:92 #2 0x232ebeb in _M_allocate /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_vector.h:150 #3 0x232ebeb in _M_allocate_and_copy<std::move_iterator<__gnu_cxx::_Hashtable_node<std::pair<const std::basic_string<char>, content::SiteInstance *> > **> > /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_vector.h:1052 #4 0x232ebeb in reserve /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/vector.tcc:74 #5 0x232ebeb in _M_initialize_buckets /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/backward/hashtable.h:577 #6 0x232ebeb in __gnu_cxx::hashtable<std::pair<std::string const, content::SiteInstance*>, std::string, __gnu_cxx::hash<std::string>, std::_Select1st<std::pair<std::string const, content::SiteInstance*> >, std::equal_to<std::string>, std::allocator<content::SiteInstance*> >::hashtable(unsigned long, __gnu_cxx::hash<std::string> const&, std::equal_to<std::string> const&, std::allocator<std::pair<std::string const, content::SiteInstance*> > const&) /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/backward/hashtable.h:334 #7 0x232cb58 in RefCounted /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/hash_map:126 #8 0x232cb58 in content::BrowsingInstance::BrowsingInstance(content::BrowserContext*) content/browser/browsing_instance.cc:18 #9 0x28d4131 in content::SiteInstance::Create(content::BrowserContext*) content/browser/site_instance_impl.cc:220 #10 0x2db9c92 in CreateTestWebContents content/public/test/test_renderer_host.cc:138 #11 0x2db9c92 in content::RenderViewHostTestHarness::SetUp() content/public/test/test_renderer_host.cc:182 #12 0xda5e2d in content::RenderFrameHostManagerTest::SetUp() content/browser/frame_host/render_frame_host_manager_unittest.cc:204 #13 0x2eea0f2 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045 #14 0x2eea0f2 in testing::Test::Run() testing/gtest/src/gtest.cc:2057 #15 0x2eec3a9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #16 0x2eed183 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #17 0x2efe463 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #18 0x2efda30 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #19 0x2efda30 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #20 0x2e7712c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #21 0x2e7712c in base::TestSuite::Run() base/test/test_suite.cc:213 #22 0x2e6aebd in Run base/callback.h:401 #23 0x2e6aebd in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback<int ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #24 0x1bfec66 in main content/test/run_all_unittests.cc:14 #25 0x7f853fc5876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 > Introduce RenderFrameProxyHost object and use it in RFHM. > > This is the first CL in a series to create RenderFrameProxy(Host) infrastructure. Before the Blink codebase is ready to transform local and remote frames, the proxy objects will keep internally the existing RF/RFH in swapped out state. This CL creates the browser side proxy object and wraps the swapped out RFH. > > BUG=357747 > > Review URL: https://codereview.chromium.org/217163007 TBR=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -333 lines) Patch
M trunk/src/content/browser/frame_host/render_frame_host_manager.h View 5 chunks +14 lines, -15 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_manager.cc View 22 chunks +120 lines, -128 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_manager_unittest.cc View 2 chunks +0 lines, -81 lines 0 comments Download
D trunk/src/content/browser/frame_host/render_frame_proxy_host.h View 1 chunk +0 lines, -88 lines 0 comments Download
D trunk/src/content/browser/frame_host/render_frame_proxy_host.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M trunk/src/content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-11 21:48:01 UTC) #1
viettrungluu
6 years, 8 months ago (2014-04-11 21:48:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r263367 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698