Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2360013002: Remove unused version of SelectBetweenCoordinates() (Closed)

Created:
4 years, 3 months ago by Tima Vaisburd
Modified:
4 years, 3 months ago
Reviewers:
Ted C, boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused version of SelectBetweenCoordinates() In ContentViewCoreImpl there are two versions of the method SelectBetweenCoordinates(), one comes from native side and another from Java side. The Java version is apparently never used. BUG=620929 Committed: https://crrev.com/d6ff51fbbf957bd3fea85fedc49f459a03a624fe Cr-Commit-Position: refs/heads/master@{#420163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Tima Vaisburd
PTAL.
4 years, 3 months ago (2016-09-21 20:01:27 UTC) #8
boliu
lgtm
4 years, 3 months ago (2016-09-21 20:13:39 UTC) #9
Ted C
lgtm
4 years, 3 months ago (2016-09-21 20:15:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360013002/1
4 years, 3 months ago (2016-09-21 21:02:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 21:10:44 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 21:13:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6ff51fbbf957bd3fea85fedc49f459a03a624fe
Cr-Commit-Position: refs/heads/master@{#420163}

Powered by Google App Engine
This is Rietveld 408576698