Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 23600047: Implement crop rect support for the merge image filter. (Closed)

Created:
7 years, 3 months ago by Stephen White
Modified:
7 years, 3 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Implement crop rect support for the merge image filter. Note: this will require rebaselining of the imagefilterscropped and testimagefilters GMs. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11387

Patch Set 1 #

Patch Set 2 : Use SkAutoTUnref<> in imagefilterscropped GM to avoid leaks; update to ToT #

Patch Set 3 : Fix the test for GPU path #

Patch Set 4 : Remove useless #include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M gm/imagefilterscropped.cpp View 1 2 3 2 chunks +12 lines, -5 lines 0 comments Download
M include/effects/SkMergeImageFilter.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 5 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Stephen White
reed@: PTAL. Thanks!
7 years, 3 months ago (2013-09-16 20:21:21 UTC) #1
reed1
lgtm
7 years, 3 months ago (2013-09-16 20:39:27 UTC) #2
Stephen White
7 years, 3 months ago (2013-09-19 17:27:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r11387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698