ninja&make/mac: Only pass -x for loadable_modules.

test/mac/gyptest-strip-default.py

Index: test/mac/gyptest-strip-default.py
===================================================================
--- test/mac/gyptest-strip-default.py	(revision 0)
+++ test/mac/gyptest-strip-default.py	(revision 0)
@@ -0,0 +1,97 @@
+#!/usr/bin/env python
+
+# Copyright (c) 2013 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+Verifies that the default STRIP_STYLEs match between different generators.
+"""
+
+import TestGyp
+
+import re
+import subprocess
+import sys
+import time
+
+if sys.platform == 'darwin':
+  test = TestGyp.TestGyp(formats=['ninja', 'make', 'xcode'])
+
+  CHDIR='strip'
+  test.run_gyp('test-defaults.gyp', chdir=CHDIR)
+
+  test.build('test-defaults.gyp', test.ALL, chdir=CHDIR)
+
+  # Lightweight check if stripping was done.
+  def OutPath(s):
+    return test.built_file_path(s, chdir=CHDIR)
+
+  def CheckNsyms(p, o_expected):
+    proc = subprocess.Popen(['nm', '-aU', p], stdout=subprocess.PIPE)
+    o = proc.communicate()[0]
+
+    # Filter out mysterious "00 0000   OPT radr://5614542" symbol which
+    # is apparently only printed on the bots (older toolchain?).
+    # Yes, "radr", not "rdar".
+    o = ''.join(filter(lambda s: 'radr://5614542' not in s, o.splitlines(True)))

[Mark Mentovai, 2013/09/14 04:23:37]

If you Google that number, https://github.com/nico/lssym is the first result
(and I see you’ve just made changes to the README today). Ha!

cctools’ misc/strip.c tells you a little bit about this, and the number shows up
in a few other files in cctools for details. I see it in cctools-839 from Xcode
4.6, so it should still be in there. If you’re seeing a difference comparing
between local runs and the bots, are you running an Xcode DP locally?

[Nico, 2013/09/14 04:30:42]

:-)
I'm running 4.6.3 locally. Weird.

+
+    o = o.replace('A', 'T')
+    o = re.sub(r'^[a-fA-F0-9]+', 'XXXXXXXX', o, flags=re.MULTILINE)

[Mark Mentovai, 2013/09/14 04:23:37]

OK, but be aware that 64-bit binaries are gonna have 16 hex digits here. This
will work, but I’m just pointing it out because you don’t NEED eight Xs here.
You could get away with one or even zero.

[Nico, 2013/09/14 04:30:42]

Done.

+    assert not proc.returncode
+    if o != o_expected:
+      print 'Stripping: Expected symbols """\n%s""", got """\n%s"""' % (
+          o_expected, o)
+      test.fail_test()
+
+  # The actual numbers here are not interesting, they just need to be the same

[Mark Mentovai, 2013/09/14 04:23:37]

But you’re not testing that the numbers are the same now. This comment should be
revised.

[Nico, 2013/09/14 04:30:42]

Done.

+  # in both the xcode and the ninja build.
+  CheckNsyms(OutPath('libsingle_dylib.dylib'),
+"""\
+XXXXXXXX S _ci
+XXXXXXXX S _i
+XXXXXXXX T _the_function
+XXXXXXXX t _the_hidden_function
+XXXXXXXX T _the_used_function
+XXXXXXXX T _the_visible_function
+""")
+  CheckNsyms(OutPath('single_so.so'),
+"""\
+XXXXXXXX S _ci
+XXXXXXXX S _i
+XXXXXXXX T _the_function
+XXXXXXXX t _the_hidden_function
+XXXXXXXX T _the_used_function
+XXXXXXXX T _the_visible_function
+""")
+  CheckNsyms(OutPath('single_exe'),
+"""\
+XXXXXXXX T __mh_execute_header
+""")
+
+  CheckNsyms(test.built_file_path(
+      'bundle_dylib.framework/Versions/A/bundle_dylib', chdir=CHDIR),
+"""\
+XXXXXXXX S _ci
+XXXXXXXX S _i
+XXXXXXXX T _the_function
+XXXXXXXX t _the_hidden_function
+XXXXXXXX T _the_used_function
+XXXXXXXX T _the_visible_function
+""")
+  CheckNsyms(test.built_file_path(
+      'bundle_so.bundle/Contents/MacOS/bundle_so', chdir=CHDIR),
+"""\
+XXXXXXXX S _ci
+XXXXXXXX S _i
+XXXXXXXX T _the_function
+XXXXXXXX T _the_used_function
+XXXXXXXX T _the_visible_function
+""")
+  CheckNsyms(test.built_file_path(
+      'bundle_exe.app/Contents/MacOS/bundle_exe', chdir=CHDIR),
+"""\
+XXXXXXXX T __mh_execute_header
+""")
+
+  test.pass_test()
Property changes on: test/mac/gyptest-strip-default.py
___________________________________________________________________
Added: svn:eol-style
   + LF