pylib/gyp/xcode_emulation.py - Issue 23600042: ninja&make/mac: Only pass -x for loadable_modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/xcode_emulation.py

Issue 23600042: ninja&make/mac: Only pass -x for loadable_modules. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/xcode_emulation.py

===================================================================

--- pylib/gyp/xcode_emulation.py (revision 1721)

+++ pylib/gyp/xcode_emulation.py (working copy)

@@ -684,7 +684,7 @@

self._Test('STRIP_INSTALLED_PRODUCT', 'YES', default='NO')):

default_strip_style = 'debugging'

- if self._IsBundle():

+ if self.spec['type'] == 'loadable_module' and self._IsBundle():

Mark Mentovai 2013/09/13 21:31:32 Wow, that’s a pretty ridiculous behavior to have t

default_strip_style = 'non-global'

elif self.spec['type'] == 'executable':

default_strip_style = 'all'

« no previous file with comments | « no previous file | test/mac/gyptest-cflags.py » ('j') | test/mac/gyptest-strip-default.py » ('J')