ninja&make/mac: Only pass -x for loadable_modules.

test/mac/strip/test-defaults.gyp

Index: test/mac/strip/test-defaults.gyp
===================================================================
--- test/mac/strip/test-defaults.gyp	(revision 0)
+++ test/mac/strip/test-defaults.gyp	(revision 0)
@@ -0,0 +1,51 @@
+# Copyright (c) 2011 Google Inc. All rights reserved.

[Mark Mentovai, 2013/09/13 16:09:05]

2013

[Nico, 2013/09/13 21:41:07]

Done.

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+{
+  'make_global_settings': [
+    ['CC', '/usr/bin/clang'],
+  ],
+  'target_defaults': {
+    'xcode_settings': {
+      'DEPLOYMENT_POSTPROCESSING': 'YES',
+      'STRIP_INSTALLED_PRODUCT': 'YES',
+    },
+  },
+  'targets': [
+    {
+      'target_name': 'single_dylib',
+      'type': 'shared_library',
+      'sources': [ 'file.c', ],

[Mark Mentovai, 2013/09/13 16:09:05]

I don’t see file.c in your CL.

I assumed you were using main.c for everything, which is where my suggestion to
use the macro comes from. If you really have a separate file, that’s cool, just
upload it. But with the additions I’ve suggested, you may actually want to put
everything in a single file (and I guess in that case, file.c is a better name)
and use a macro to choose the name of the function.

[Nico, 2013/09/13 21:41:07]

It's already there, from the test.gyp test in the same directory. It should now
be visible as I tweaked it a bit

+    },
+    {
+      'target_name': 'single_so',
+      'type': 'loadable_module',
+      'sources': [ 'file.c', ],
+    },
+    {
+      'target_name': 'single_exe',
+      'type': 'executable',
+      'sources': [ 'main.c', ],
+    },
+
+    {
+      'target_name': 'bundle_dylib',
+      'type': 'shared_library',
+      'mac_bundle': '1',
+      'sources': [ 'file.c', ],
+    },
+    {
+      'target_name': 'bundle_so',
+      'type': 'loadable_module',
+      'mac_bundle': '1',
+      'sources': [ 'file.c', ],
+    },
+    {
+      'target_name': 'bundle_exe',
+      'type': 'executable',
+      'mac_bundle': '1',
+      'sources': [ 'main.c', ],
+    },
+  ],

[Mark Mentovai, 2013/09/13 16:09:05]

Do you want to test a few targets with STRIP_STYLE set explicitly? If you wanted
to do that, I think it’d be fine to just have three executable targets.

[Mark Mentovai, 2013/09/13 21:31:32]

I wrote:
You left this comment unaddressed and unreplied-to.

[Nico, 2013/09/13 21:41:07]

test.gyp in this folder already covers explicit STRIP_STYLE settings.

+}
+

[Mark Mentovai, 2013/09/13 16:09:05]

blank line

[Mark Mentovai, 2013/09/13 21:31:32]

I wrote:
This one too. And probably you didn’t see the two at the top of this file,
either.

[Nico, 2013/09/13 21:41:07]

Done.

Property changes on: test/mac/strip/test-defaults.gyp
___________________________________________________________________
Added: svn:eol-style
   + LF