ninja&make/mac: Only pass -x for loadable_modules.

test/mac/gyptest-strip-default.py

+#!/usr/bin/env python
+
+# Copyright (c) 2013 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+Verifies that the default STRIP_STYLEs match between different generators.
+"""
+
+import TestGyp
+
+import re
+import subprocess
+import sys
+import time
+
+if sys.platform == 'darwin':
+  test = TestGyp.TestGyp(formats=['ninja', 'make', 'xcode'])
+
+  CHDIR='strip'
+  test.run_gyp('test-defaults.gyp', chdir=CHDIR)
+
+  test.build('test-defaults.gyp', test.ALL, chdir=CHDIR)
+
+  # Lightweight check if stripping was done.
+  def OutPath(s):
+    return test.built_file_path(s, chdir=CHDIR)
+
+  def CheckNsyms(p, o_expected):

[Mark Mentovai, 2013/09/13 21:31:32]

This is not checking nsyms now, it’s checking syms.

+    proc = subprocess.Popen(['nm', '-a', p], stdout=subprocess.PIPE)
+    o = proc.communicate()[0]
+    assert not proc.returncode
+    if o != o_expected:
+      print 'Stripping: Expected symbols """\n%s""", got """\n%s"""' % (
+          o_expected, o)
+      test.fail_test()
+
+  # The actual numbers here are not interesting, they just need to be the same
+  # in both the xcode and the ninja build.
+  CheckNsyms(OutPath('libsingle_dylib.dylib'),
+"""\
+00000fb3 T _the_function

[Mark Mentovai, 2013/09/13 21:31:32]

The numbers here will vary depending on the compiler and linker and how they’re
running. You can’t hard-code this stuff, but if Xcode and ninja are both using
the same compiler and linker, you can compare one against the other. These here,
for example, look like 32-bit x86. Sorry, I thought that was obvious. Does that
make this harder to test?

You’d still have this problem, although to a slightly lesser degree, if you were
hard-coding specific nsyms values to match.

Although any option is going to have some amount of flake, maybe a good
compromise solution is to add -j to nm so that it won’t print addresses. That
should at least be approximately as stable as counting symbols, but it gets you
extra protection against “what if Xcode strips different symbols from ninja, but
they both strip the same number?” -j unfortunately also removes the section
value. If you wanted to keep that, you could also process the nm output to
remove the number.

+00000fa9 t _the_hidden_function
+00000fa4 T _the_used_function
+00000fae T _the_visible_function
+         U dyld_stub_binder
+""")
+  CheckNsyms(OutPath('single_so.so'),
+"""\
+00000fb3 T _the_function
+00000fa9 t _the_hidden_function
+00000fa4 T _the_used_function
+00000fae T _the_visible_function
+         U dyld_stub_binder
+""")
+  CheckNsyms(OutPath('single_exe'),
+"""\
+00001000 T __mh_execute_header
+         U dyld_stub_binder
+""")
+
+  CheckNsyms(test.built_file_path(
+      'bundle_dylib.framework/Versions/A/bundle_dylib', chdir=CHDIR),
+"""\
+00000fb3 T _the_function
+00000fa9 t _the_hidden_function
+00000fa4 T _the_used_function
+00000fae T _the_visible_function
+         U dyld_stub_binder
+""")
+  CheckNsyms(test.built_file_path(
+      'bundle_so.bundle/Contents/MacOS/bundle_so', chdir=CHDIR),
+"""\
+00000fb3 T _the_function
+00000fa4 T _the_used_function
+00000fae T _the_visible_function
+         U dyld_stub_binder
+""")
+  CheckNsyms(test.built_file_path(
+      'bundle_exe.app/Contents/MacOS/bundle_exe', chdir=CHDIR),
+"""\
+00001000 T __mh_execute_header
+         U dyld_stub_binder
+""")
+
+  test.pass_test()