Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 23600040: Revert "Clean up after r16292 (disable optimization for StringWrappers)." (Closed)

Created:
7 years, 3 months ago by Yang
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Revert "Clean up after r16292 (disable optimization for StringWrappers)." R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -65 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +19 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +15 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +16 lines, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +15 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +5 lines, -11 lines 0 comments Download
M test/mjsunit/regress/regress-2855.js View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 3 months ago (2013-09-12 11:14:28 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
7 years, 3 months ago (2013-09-12 11:14:42 UTC) #2
Yang
7 years, 3 months ago (2013-09-12 11:15:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16679.

Powered by Google App Engine
This is Rietveld 408576698