Source/bindings/v8/V8AbstractEventListener.cpp - Issue 23600034: Use TRYCATCH_FOR_V8STRINGRESOURCE in AbstractEventListener::invokeEventHandler()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8AbstractEventListener.cpp

Issue 23600034: Use TRYCATCH_FOR_V8STRINGRESOURCE in AbstractEventListener::invokeEventHandler() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use a frame in the test Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/events/before-unload-return-bad-value.html ('K') | « LayoutTests/fast/events/before-unload-return-bad-value-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/V8AbstractEventListener.cpp

diff --git a/Source/bindings/v8/V8AbstractEventListener.cpp b/Source/bindings/v8/V8AbstractEventListener.cpp

index e6937c99d53f9f2caf60cd433dde6f810d0f6471..e6b3de91b411885d3368a198eb5479c802da8b5e 100644

--- a/Source/bindings/v8/V8AbstractEventListener.cpp

+++ b/Source/bindings/v8/V8AbstractEventListener.cpp

@@ -156,8 +156,10 @@ void V8AbstractEventListener::invokeEventHandler(ScriptExecutionContext* context

if (returnValue.IsEmpty())

return;

- if (!returnValue->IsNull() && !returnValue->IsUndefined() && event->isBeforeUnloadEvent())

- toBeforeUnloadEvent(event)->setReturnValue(toWebCoreString(returnValue));

+ if (!returnValue->IsNull() && !returnValue->IsUndefined() && event->isBeforeUnloadEvent()) {

+ V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, stringReturnValue, returnValue);

+ toBeforeUnloadEvent(event)->setReturnValue(stringReturnValue);

+ }

if (m_isAttribute && shouldPreventDefault(returnValue))

event->preventDefault();

« LayoutTests/fast/events/before-unload-return-bad-value.html ('K') | « LayoutTests/fast/events/before-unload-return-bad-value-expected.txt ('k') | no next file » | no next file with comments »