LayoutTests/fast/events/before-unload-return-bad-value.html - Issue 23600034: Use TRYCATCH_FOR_V8STRINGRESOURCE in AbstractEventListener::invokeEventHandler()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/before-unload-return-bad-value.html

Issue 23600034: Use TRYCATCH_FOR_V8STRINGRESOURCE in AbstractEventListener::invokeEventHandler() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use a frame in the test Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../js/resources/js-test-pre.js"></script>

	5 <script>

	6 description("Tests that an exception is thrown when the value returned in the be foreunload callback cannot be converted to a String");

	7 window.jsTestIsAsync = true;

	8

	9 function test(frame) {

	10 frame.contentWindow.onbeforeunload = function(event) {

	11 return {toString: function() { throw "Exception in toString()"; }};

	12 };

	13

	14 frame.contentWindow.location.href = "resources/does-not-exist.html";

	15 setTimeout(finishJSTest, 0);
	do-not-use 2013/09/11 15:13:33 I updated the test to use an iframe. This way, we I updated the test to use an iframe. This way, we no longer need to use testRunner.setShouldStayOnPageAfterHandlingBeforeUnload(). Note however that the test still works only if I keep both setTimeout() calls. I really don't get it.
	16 }

	17

	18 var testMessage;

	19 window.onerror = function(msg) {

	20 testMessage = msg;

	21 testPassed("Exception was thrown");

	22 shouldBeEqualToString("testMessage", "Uncaught Exception in toString()");

	23 setTimeout(finishJSTest, 0);

	24 return true;

	25 };

	26 </script>

	27 </head>

	28 <body>

	29 <iframe onload="test(this)" src="resources/onclick.html"></iframe>

	30 <script src="../js/resources/js-test-post.js"></script>

	31 </body>

	32 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/before-unload-return-bad-value-expected.txt » ('j') | no next file with comments »