LayoutTests/fast/events/before-unload-return-bad-value.html - Issue 23600034: Use TRYCATCH_FOR_V8STRINGRESOURCE in AbstractEventListener::invokeEventHandler()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/before-unload-return-bad-value.html

Issue 23600034: Use TRYCATCH_FOR_V8STRINGRESOURCE in AbstractEventListener::invokeEventHandler() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../js/resources/js-test-pre.js"></script>

	5 <script>

	6 if (window.testRunner)

	7 testRunner.setShouldStayOnPageAfterHandlingBeforeUnload(true);

	8

	9 window.onload = function() {

	10 window.location.href = "resources/does-not-exist.html";

	11 setTimeout(finishJSTest, 0);
	arv (Not doing code reviews) 2013/09/11 13:42:19 Why is this needed? window.onerror calls finishJST Why is this needed? window.onerror calls finishJSTest already. do-not-use 2013/09/11 14:12:29 I had it in case it did not throw, to avoid a time Show quoted text On 2013/09/11 13:42:19, arv wrote: > Why is this needed? window.onerror calls finishJSTest already. I had it in case it did not throw, to avoid a timeout and fail quickly. However, now I noticed that if I remove this setTimeout() and keep only the second one, the test times out... For some reason, the test does not time out only if I keep BOTH setTimeout() calls.
	12 }
	arv (Not doing code reviews) 2013/09/11 13:42:19 semicolons after assignment. semicolons after assignment.
	13

	14 var nonConvertibleToString = {toString: function() { throw "Exception in toStrin g()"; }};

	15

	16 var testMessage;

	17 window.onerror = function(msg) {

	18 testMessage = msg;

	19 shouldBeEqualToString("testMessage", "Uncaught Exception in toString()");

	20 setTimeout(finishJSTest, 0);
	do-not-use 2013/09/11 09:00:43 I am not quite sure why this setTimeout() is neede I am not quite sure why this setTimeout() is needed but the test times out otherwise. haraken 2013/09/11 09:08:44 Looks strange. arv, do you have any idea? Show quoted text On 2013/09/11 09:00:43, Christophe Dumez wrote: > I am not quite sure why this setTimeout() is needed but the test times out > otherwise. Looks strange. arv, do you have any idea? arv (Not doing code reviews) 2013/09/11 13:42:19 I'm not sure. Maybe it is related to setShouldStay Show quoted text On 2013/09/11 09:08:44, haraken wrote: > On 2013/09/11 09:00:43, Christophe Dumez wrote: > > I am not quite sure why this setTimeout() is needed but the test times out > > otherwise. > > Looks strange. arv, do you have any idea? I'm not sure. Maybe it is related to setShouldStayOnPageAfterHandlingBeforeUnload somehow?
	21 return true;

	22 }

	23

	24 window.onbeforeunload = function(event) {

	25 return nonConvertibleToString;

	26 }

	27 </script>

	28 </head>

	29 <body>

	30 <script>

	31 description("Tests that an exception is thrown when the value returned in the be foreunload callback cannot be converted to a String");

	32 window.jsTestIsAsync = true;
	arv (Not doing code reviews) 2013/09/11 13:42:19 move this to other script block, before if window. move this to other script block, before if window.testRunner.
	33 </script>

	34 <script src="../js/resources/js-test-post.js"></script>

	35 </body>

	36 </html>

	37

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/before-unload-return-bad-value-expected.txt » ('j') | no next file with comments »