Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(256)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Issue
23600024
: Revert 222242 "[Activity Log] when extension is uninstalled, del..." (Closed)
Created:
7 years, 3 months ago by
earthdok
Modified:
7 years, 3 months ago
Reviewers:
felt
CC:
chromium-reviews
Base URL:
svn://svn.chromium.org/chrome/
Visibility:
Public.
More Reviews
Description
Revert 222242 "[Activity Log] when extension is uninstalled, del..." Reverted due to memory leaks. BUG=
288708
> [Activity Log] when extension is uninstalled, delete data about it > > When a user uninstalls an extension, all of the data about that extension is removed from the activity log database. This is a privacy measure. > > BUG=
244841
>
R=mpcomplete@chromium.org
> > Review URL:
https://chromiumcodereview.appspot.com/23983014
TBR=felt@chromium.org
Committed:
https://src.chromium.org/viewvc/chrome?view=rev&revision=222256
Patch Set 1
#
Created:
7 years, 3 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+11 lines, -256 lines
)
Patch
M
trunk/src/chrome/browser/extensions/activity_log/activity_log.cc
View
2 chunks
+9 lines, -13 lines
0 comments
Download
M
trunk/src/chrome/browser/extensions/activity_log/activity_log_policy.h
View
1 chunk
+0 lines, -3 lines
0 comments
Download
M
trunk/src/chrome/browser/extensions/activity_log/activity_log_unittest.cc
View
3 chunks
+2 lines, -44 lines
0 comments
Download
M
trunk/src/chrome/browser/extensions/activity_log/counting_policy.h
View
2 chunks
+0 lines, -7 lines
0 comments
Download
M
trunk/src/chrome/browser/extensions/activity_log/counting_policy.cc
View
2 chunks
+0 lines, -37 lines
0 comments
Download
M
trunk/src/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
View
1 chunk
+0 lines, -57 lines
0 comments
Download
M
trunk/src/chrome/browser/extensions/activity_log/fullstream_ui_policy.h
View
2 chunks
+0 lines, -7 lines
0 comments
Download
M
trunk/src/chrome/browser/extensions/activity_log/fullstream_ui_policy.cc
View
2 chunks
+0 lines, -31 lines
0 comments
Download
M
trunk/src/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc
View
1 chunk
+0 lines, -57 lines
0 comments
Download
Messages
Total messages: 2 (0 generated)
Expand Messages
|
Collapse Messages
earthdok
7 years, 3 months ago (2013-09-10 13:00:03 UTC)
#1
earthdok
Committed patchset #1 manually as r222256.
7 years, 3 months ago (2013-09-10 13:00:29 UTC)
#2
Message was sent while issue was closed.
Committed patchset #1 manually as r222256.
Expand Messages
|
Collapse Messages
Issue 23600024: Revert 222242 "[Activity Log] when extension is uninstalled, del..." (Closed)
Created 7 years, 3 months ago by earthdok
Modified 7 years, 3 months ago
Reviewers: felt
Base URL: svn://svn.chromium.org/chrome/
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue
23600024:
Revert 222242 "[Activity Log] when extension is uninstalled, del..." (Closed)
