Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 23600023: Remove dead strings from heap.h (Closed)

Created:
7 years, 3 months ago by titzer
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Remove dead strings from heap.h BUG= R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16639

Patch Set 1 #

Patch Set 2 : Rerun make grokdump. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.h View 6 chunks +1 line, -10 lines 0 comments Download
M tools/v8heapconst.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
Remove internalized strings that not referenced from either their factory method, their root index, and ...
7 years, 3 months ago (2013-09-10 12:22:43 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-09-10 12:59:35 UTC) #2
titzer
7 years, 3 months ago (2013-09-11 08:58:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16639 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698