Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23600014: Rename OS(UNIX) to OS(POSIX) (Closed)

Created:
7 years, 3 months ago by lgombos
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, jamesr, caseq+blink_chromium.org, dsinclair, yurys+blink_chromium.org, abarth-chromium, danakj, dglazkov+blink, Rik, devtools-reviews_chromium.org, pdr., loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, groby+blinkspell_chromium.org, Stephen Chennney, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename OS(UNIX) to OS(POSIX) to be consistent with the rest of chromium and build_config.h. BUG=286645 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M Source/config.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Settings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/Scrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/FontCustomPlatformData.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/FontPlatformData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/EditorClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/ByteOrder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/DataLog.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/FastMalloc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/PageAllocator.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/wtf/PartitionAllocTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/wtf/ProcessID.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/RandomNumberSeed.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/StringExtras.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/TCSpinLock.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
lgombos
Alternatively build_config.h should call these OS_UNIX, but I think POSIX is a better name. Either ...
7 years, 3 months ago (2013-09-09 01:47:25 UTC) #1
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-09 02:43:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23600014/1
7 years, 3 months ago (2013-09-09 04:27:58 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 05:23:33 UTC) #4
Message was sent while issue was closed. 
Change committed as 157438

Powered by Google App Engine
This is Rietveld 408576698