Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: src/api.cc

Issue 23600011: Handlify JSObject::DeleteHiddenProperty method. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3833 matching lines...) Expand 10 before | Expand all | Expand 10 after
3844 3844
3845 bool v8::Object::DeleteHiddenValue(v8::Handle<v8::String> key) { 3845 bool v8::Object::DeleteHiddenValue(v8::Handle<v8::String> key) {
3846 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); 3846 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
3847 ON_BAILOUT(isolate, "v8::DeleteHiddenValue()", return false); 3847 ON_BAILOUT(isolate, "v8::DeleteHiddenValue()", return false);
3848 ENTER_V8(isolate); 3848 ENTER_V8(isolate);
3849 i::HandleScope scope(isolate); 3849 i::HandleScope scope(isolate);
3850 i::Handle<i::JSObject> self = Utils::OpenHandle(this); 3850 i::Handle<i::JSObject> self = Utils::OpenHandle(this);
3851 i::Handle<i::String> key_obj = Utils::OpenHandle(*key); 3851 i::Handle<i::String> key_obj = Utils::OpenHandle(*key);
3852 i::Handle<i::String> key_string = 3852 i::Handle<i::String> key_string =
3853 isolate->factory()->InternalizeString(key_obj); 3853 isolate->factory()->InternalizeString(key_obj);
3854 self->DeleteHiddenProperty(*key_string); 3854 i::JSObject::DeleteHiddenProperty(self, key_string);
3855 return true; 3855 return true;
3856 } 3856 }
3857 3857
3858 3858
3859 namespace { 3859 namespace {
3860 3860
3861 static i::ElementsKind GetElementsKindFromExternalArrayType( 3861 static i::ElementsKind GetElementsKindFromExternalArrayType(
3862 ExternalArrayType array_type) { 3862 ExternalArrayType array_type) {
3863 switch (array_type) { 3863 switch (array_type) {
3864 case kExternalByteArray: 3864 case kExternalByteArray:
(...skipping 3981 matching lines...) Expand 10 before | Expand all | Expand 10 after
7846 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate()); 7846 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
7847 Address callback_address = 7847 Address callback_address =
7848 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback)); 7848 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
7849 VMState<EXTERNAL> state(isolate); 7849 VMState<EXTERNAL> state(isolate);
7850 ExternalCallbackScope call_scope(isolate, callback_address); 7850 ExternalCallbackScope call_scope(isolate, callback_address);
7851 return callback(info); 7851 return callback(info);
7852 } 7852 }
7853 7853
7854 7854
7855 } } // namespace v8::internal 7855 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698