Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: appengine/swarming/elements/res/imp/botlist/bot-list-summary.html

Issue 2359993002: Medium sized improvements to bot-list and task-list (Closed) Base URL: git@github.com:luci/luci-py@master
Patch Set: fix dangling div Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!-- 1 <!--
2 This in an HTML Import-able file that contains the definition 2 This in an HTML Import-able file that contains the definition
3 of the following elements: 3 of the following elements:
4 4
5 <bot-list-summary> 5 <bot-list-summary>
6 6
7 7
8 Usage: 8 Usage:
9 9
10 <bot-list-summary></bot-list-summary> 10 <bot-list-summary></bot-list-summary>
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 return "status:" + filter; 182 return "status:" + filter;
183 } else { 183 } else {
184 return "task:" + filter; 184 return "task:" + filter;
185 } 185 }
186 }, 186 },
187 187
188 _makeURL: function(filter, preserveOthers) { 188 _makeURL: function(filter, preserveOthers) {
189 if (preserveOthers) { 189 if (preserveOthers) {
190 var fstr = encodeURIComponent(this._getFilterStr(filter)); 190 var fstr = encodeURIComponent(this._getFilterStr(filter));
191 if (window.location.href.indexOf(fstr) === -1) { 191 if (window.location.href.indexOf(fstr) === -1) {
192 return window.location.href + "&filters=" + fstr; 192 return window.location.href + "&f=" + fstr;
193 } 193 }
194 // The filter is already on the list. 194 // The filter is already on the list.
195 return undefined; 195 return undefined;
196 } 196 }
197 var params = { 197 var params = {
198 sort: [this.sort], 198 s: [this.sort],
199 columns: this.columns, 199 c: this.columns,
200 verbose: [this.verbose], 200 v: [this.verbose],
201 } 201 }
202 if (filter) { 202 if (filter) {
203 params["filters"] = [this._getFilterStr(filter)]; 203 params["f"] = [this._getFilterStr(filter)];
204 } 204 }
205 205
206 return window.location.href.split('?')[0] + '?' + sk.query.fromParamSet( params); 206 return window.location.href.split('?')[0] + '?' + sk.query.fromParamSet( params);
207 }, 207 },
208 208
209 _recount: function() { 209 _recount: function() {
210 var curr = { 210 var curr = {
211 all: 0, 211 all: 0,
212 alive: 0, 212 alive: 0,
213 busy: 0, 213 busy: 0,
(...skipping 18 matching lines...) Expand all
232 } else { 232 } else {
233 curr.alive++; 233 curr.alive++;
234 } 234 }
235 curr.all++; 235 curr.all++;
236 }.bind(this)); 236 }.bind(this));
237 this.set("_currently_showing", curr); 237 this.set("_currently_showing", curr);
238 } 238 }
239 }); 239 });
240 </script> 240 </script>
241 </dom-module> 241 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698