Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: build/util/branding.gni

Issue 2359953003: Fix up the Mac installer’s Info.plist, build with branding info (Closed)
Patch Set: Remove an unused gn dependency, add .installer to the bundle ID in the Info.plist instead of BUILD.gn Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/mac/app/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/util/branding.gni
diff --git a/build/util/branding.gni b/build/util/branding.gni
index c38d2a9fc72c177b5ee8e6bf05471c0758d5a757..cadd1a3441586bf246b9531dd76ca3977bbe6111 100644
--- a/build/util/branding.gni
+++ b/build/util/branding.gni
@@ -14,10 +14,13 @@
import("//build/config/chrome_build.gni")
-_branding_dictionary_template = "full_name = \"@PRODUCT_FULLNAME@\" " +
- "short_name = \"@PRODUCT_SHORTNAME@\" " +
- "bundle_id = \"@MAC_BUNDLE_ID@\" " +
- "creator_code = \"@MAC_CREATOR_CODE@\" "
+_branding_dictionary_template =
+ "full_name = \"@PRODUCT_FULLNAME@\" " +
+ "short_name = \"@PRODUCT_SHORTNAME@\" " +
+ "bundle_id = \"@MAC_BUNDLE_ID@\" " +
+ "creator_code = \"@MAC_CREATOR_CODE@\" " +
+ "installer_full_name = \"@PRODUCT_INSTALLER_FULLNAME@\" " +
+ "installer_short_name = \"@PRODUCT_INSTALLER_SHORTNAME@\" "
_branding_file = "//chrome/app/theme/$branding_path_component/BRANDING"
_result = exec_script("version.py",
@@ -32,6 +35,8 @@ _result = exec_script("version.py",
chrome_product_full_name = _result.full_name
chrome_product_short_name = _result.short_name
+chrome_product_installer_full_name = _result.installer_full_name
+chrome_product_installer_short_name = _result.installer_short_name
if (is_mac) {
chrome_mac_bundle_id = _result.bundle_id
« no previous file with comments | « no previous file | chrome/installer/mac/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698