Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2359933003: chromium.fyi: Set up a 'ClangToTAndroid (dbg)' buildbot (Closed)

Created:
4 years, 3 months ago by hans
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

chromium.fyi: Set up a 'ClangToTAndroid (dbg)' buildbot We previously did not have any bots building in this configuration, which broke in the last Clang roll. BUG=648979 Committed: https://chromium.googlesource.com/chromium/tools/build/+/d8ae47ba43e4ac53ca6cf8325fec3ccffa60c4bb

Patch Set 1 #

Total comments: 7

Patch Set 2 : Use builder list of the existing slave #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -25 lines) Patch
M masters/master.chromium.fyi/master.cfg View 3 chunks +9 lines, -0 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +5 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/config.py View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 chunk +24 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroid__dbg_.json View 11 chunks +53 lines, -25 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
hans
Mostly cargo-culted from other configs. Is there some way to see what args well be ...
4 years, 3 months ago (2016-09-21 23:18:46 UTC) #2
Nico
On 2016/09/21 23:18:46, hans wrote: > Mostly cargo-culted from other configs. Is there some way ...
4 years, 3 months ago (2016-09-21 23:23:22 UTC) #3
Nico
lgtm https://codereview.chromium.org/2359933003/diff/1/masters/master.chromium.fyi/slaves.cfg File masters/master.chromium.fyi/slaves.cfg (right): https://codereview.chromium.org/2359933003/diff/1/masters/master.chromium.fyi/slaves.cfg#newcode425 masters/master.chromium.fyi/slaves.cfg:425: 'hostname': 'slave5-c1', wow, you got a machine already? ...
4 years, 3 months ago (2016-09-21 23:27:22 UTC) #4
hans
> gn args is handled src-side these days, see chrome/src/tools/mb/mb_config.pyl I see. I assume that ...
4 years, 3 months ago (2016-09-21 23:55:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359933003/1
4 years, 3 months ago (2016-09-22 16:04:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/316b7cb817d1a510)
4 years, 3 months ago (2016-09-22 16:15:34 UTC) #9
Nico
https://codereview.chromium.org/2359933003/diff/1/masters/master.chromium.fyi/slaves.cfg File masters/master.chromium.fyi/slaves.cfg (right): https://codereview.chromium.org/2359933003/diff/1/masters/master.chromium.fyi/slaves.cfg#newcode425 masters/master.chromium.fyi/slaves.cfg:425: 'hostname': 'slave5-c1', On 2016/09/21 23:55:03, hans wrote: > On ...
4 years, 3 months ago (2016-09-22 16:18:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359933003/20001
4 years, 3 months ago (2016-09-22 16:22:14 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 16:26:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/d8ae47ba43e4ac53ca6c...

Powered by Google App Engine
This is Rietveld 408576698