Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 235993003: Revert "Modify supercluster multiplier logic" (http://crrev.com/231663006). (Closed)

Created:
6 years, 8 months ago by skobes
Modified:
6 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink, RyanS
Visibility:
Public.

Description

Revert "Modify supercluster multiplier logic" (http://crrev.com/231663006). Appears to be causing crashes on Android perf bots. BUG=362975 TBR=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -73 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/text-autosizing/similar-clusters.html View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/fast/text-autosizing/supercluster-multiple-layout.html View 1 chunk +0 lines, -47 lines 0 comments Download
M LayoutTests/virtual/fasttextautosizing/fast/text-autosizing/similar-clusters-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/FastTextAutosizer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/FastTextAutosizer.cpp View 3 chunks +25 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
skobes
6 years, 8 months ago (2014-04-13 22:24:21 UTC) #1
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 8 months ago (2014-04-13 22:25:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/235993003/1
6 years, 8 months ago (2014-04-13 22:25:31 UTC) #3
pdr.
LGTM I was hoping we were just missing a null check though. The SFO office ...
6 years, 8 months ago (2014-04-13 22:26:28 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-13 23:28:12 UTC) #5
Message was sent while issue was closed.
Change committed as 171409

Powered by Google App Engine
This is Rietveld 408576698