gm/rebaseline_server/static/loader.js - Issue 235993002: rebaseline_server: fix sorting by perceptual diff column

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/static/loader.js

Issue 235993002: rebaseline_server: fix sorting by perceptual diff column (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/rebaseline_server/static/loader.js

diff --git a/gm/rebaseline_server/static/loader.js b/gm/rebaseline_server/static/loader.js

index 562426d4068a98872c883a8d02364293d9ffdf86..dc33bd0a93a971b01cf303e86627953ee8d0589f 100644

--- a/gm/rebaseline_server/static/loader.js

+++ b/gm/rebaseline_server/static/loader.js

@@ -102,7 +102,7 @@ Loader.controller(

$scope.imagePairs = data[constants.KEY__IMAGEPAIRS];

$scope.imageSets = data[constants.KEY__IMAGESETS];

$scope.sortColumnSubdict = constants.KEY__DIFFERENCE_DATA;

- $scope.sortColumnKey = constants.KEY__DIFFERENCE_DATA__WEIGHTED_DIFF;

+ $scope.sortColumnKey = constants.KEY__DIFFERENCE_DATA__PERCEPTUAL_DIFF;

$scope.showSubmitAdvancedSettings = false;

$scope.submitAdvancedSettings = {};

@@ -411,7 +411,7 @@ Loader.controller(

($scope.sortColumnKey ==

constants.KEY__DIFFERENCE_DATA__PERCENT_DIFF_PIXELS) ||

($scope.sortColumnKey ==

- constants.KEY__DIFFERENCE_DATA__WEIGHTED_DIFF));

+ constants.KEY__DIFFERENCE_DATA__PERCEPTUAL_DIFF));

$scope.filteredImagePairs =

$filter("orderBy")(

« no previous file with comments | « no previous file | gm/rebaseline_server/static/view.html » ('j') | no next file with comments »