Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: src/heap/heap.h

Issue 2359903002: [heap] New heuristics for incremental marking step size. (Closed)
Patch Set: use space iterator Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index 60c2464f5a74e1386d6fee87927b1d12c043dd2d..edce0d953d13ae2ba1e0274ca096b7c80bd10932 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -1372,16 +1372,18 @@ class Heap {
}
void UpdateOldGenerationAllocationCounter() {
- old_generation_allocation_counter_ = OldGenerationAllocationCounter();
+ old_generation_allocation_counter_at_last_gc_ =
+ OldGenerationAllocationCounter();
}
size_t OldGenerationAllocationCounter() {
- return old_generation_allocation_counter_ + PromotedSinceLastGC();
+ return old_generation_allocation_counter_at_last_gc_ +
+ PromotedSinceLastGC();
}
// This should be used only for testing.
- void set_old_generation_allocation_counter(size_t new_value) {
- old_generation_allocation_counter_ = new_value;
+ void set_old_generation_allocation_counter_at_last_gc(size_t new_value) {
+ old_generation_allocation_counter_at_last_gc_ = new_value;
}
size_t PromotedSinceLastGC() {
@@ -1708,10 +1710,6 @@ class Heap {
// Flush the number to string cache.
void FlushNumberStringCache();
- // TODO(hpayer): Allocation site pretenuring may make this method obsolete.
- // Re-visit incremental marking heuristics.
- bool IsHighSurvivalRate() { return high_survival_rate_period_length_ > 0; }
-
void ConfigureInitialOldGenerationSize();
bool HasLowYoungGenerationAllocationRate();
@@ -2186,7 +2184,6 @@ class Heap {
GCTracer* tracer_;
- int high_survival_rate_period_length_;
intptr_t promoted_objects_size_;
double promotion_ratio_;
double promotion_rate_;
@@ -2245,7 +2242,7 @@ class Heap {
// This counter is increased before each GC and never reset. To
// account for the bytes allocated since the last GC, use the
// OldGenerationAllocationCounter() function.
- size_t old_generation_allocation_counter_;
+ size_t old_generation_allocation_counter_at_last_gc_;
// The size of objects in old generation after the last MarkCompact GC.
size_t old_generation_size_at_last_gc_;
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698