Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 2359903002: [heap] New heuristics for incremental marking step size. (Closed)
Patch Set: comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | src/heap/incremental-marking.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 3223 matching lines...) Expand 10 before | Expand all | Expand 10 after
3234 3234
3235 3235
3236 void RecordWriteStub::CheckNeedsToInformIncrementalMarker( 3236 void RecordWriteStub::CheckNeedsToInformIncrementalMarker(
3237 MacroAssembler* masm, 3237 MacroAssembler* masm,
3238 OnNoNeedToInformIncrementalMarker on_no_need, 3238 OnNoNeedToInformIncrementalMarker on_no_need,
3239 Mode mode) { 3239 Mode mode) {
3240 Label on_black; 3240 Label on_black;
3241 Label need_incremental; 3241 Label need_incremental;
3242 Label need_incremental_pop_scratch; 3242 Label need_incremental_pop_scratch;
3243 3243
3244 __ and_(regs_.scratch0(), regs_.object(), Operand(~Page::kPageAlignmentMask));
3245 __ ldr(regs_.scratch1(),
3246 MemOperand(regs_.scratch0(),
3247 MemoryChunk::kWriteBarrierCounterOffset));
3248 __ sub(regs_.scratch1(), regs_.scratch1(), Operand(1), SetCC);
3249 __ str(regs_.scratch1(),
3250 MemOperand(regs_.scratch0(),
3251 MemoryChunk::kWriteBarrierCounterOffset));
3252 __ b(mi, &need_incremental);
3253
3254 // Let's look at the color of the object: If it is not black we don't have 3244 // Let's look at the color of the object: If it is not black we don't have
3255 // to inform the incremental marker. 3245 // to inform the incremental marker.
3256 __ JumpIfBlack(regs_.object(), regs_.scratch0(), regs_.scratch1(), &on_black); 3246 __ JumpIfBlack(regs_.object(), regs_.scratch0(), regs_.scratch1(), &on_black);
3257 3247
3258 regs_.Restore(masm); 3248 regs_.Restore(masm);
3259 if (on_no_need == kUpdateRememberedSetOnNoNeedToInformIncrementalMarker) { 3249 if (on_no_need == kUpdateRememberedSetOnNoNeedToInformIncrementalMarker) {
3260 __ RememberedSetHelper(object(), address(), value(), save_fp_regs_mode(), 3250 __ RememberedSetHelper(object(), address(), value(), save_fp_regs_mode(),
3261 MacroAssembler::kReturnAtEnd); 3251 MacroAssembler::kReturnAtEnd);
3262 } else { 3252 } else {
3263 __ Ret(); 3253 __ Ret();
(...skipping 1916 matching lines...) Expand 10 before | Expand all | Expand 10 after
5180 CallApiFunctionAndReturn(masm, api_function_address, thunk_ref, 5170 CallApiFunctionAndReturn(masm, api_function_address, thunk_ref,
5181 kStackUnwindSpace, NULL, return_value_operand, NULL); 5171 kStackUnwindSpace, NULL, return_value_operand, NULL);
5182 } 5172 }
5183 5173
5184 #undef __ 5174 #undef __
5185 5175
5186 } // namespace internal 5176 } // namespace internal
5187 } // namespace v8 5177 } // namespace v8
5188 5178
5189 #endif // V8_TARGET_ARCH_ARM 5179 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | src/heap/incremental-marking.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698