Issue 2359893002: Open |current_url| in Chrome when |previous_url| is empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2359893002: Open |current_url| in Chrome when |previous_url| is empty (Closed)

Created:
4 years, 3 months ago by Yusuke Sato

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Open |current_url| in Chrome when |previous_url| is empty to prevent the disambig window from being shown when it shouldn't be. BUG=640393 TEST=see repro steps in b/31043273 TEST=try Review-Url: https://codereview.chromium.org/2277533002 Cr-Commit-Position: refs/heads/master@{#419900} (cherry picked from commit 772b47ff82c6450985f727a6fa13d3366143a745) Committed: https://chromium.googlesource.com/chromium/src/+/36eddf219afe14f4858f5405f0c7b91fe2320426

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -12 lines)			Patch
M	chrome/browser/chromeos/arc/arc_navigation_throttle.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/arc/arc_navigation_throttle.cc	View	4 chunks	+30 lines, -8 lines	0 comments	Download
A	chrome/browser/chromeos/arc/arc_navigation_throttle_unittest.cc	View	1 chunk	+41 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Yusuke Sato

4 years, 3 months ago (2016-09-21 17:00:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
36eddf219afe14f4858f5405f0c7b91fe2320426.