Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2359883002: Make ARMI::SwitchOutputDevice work after Stop is called. (Closed)

Created:
4 years, 3 months ago by Guido Urdaneta
Modified:
4 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ARMI::SwitchOutputDevice work after Stop is called. BUG=644622 Committed: https://crrev.com/4f36a74f8081e3830a9c9fb48854c1a831cf6086 Cr-Commit-Position: refs/heads/master@{#420269}

Patch Set 1 : fix #

Patch Set 2 : Update unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -46 lines) Patch
M media/base/audio_renderer_mixer_input.h View 1 chunk +0 lines, -6 lines 0 comments Download
M media/base/audio_renderer_mixer_input.cc View 4 chunks +11 lines, -31 lines 0 comments Download
M media/base/audio_renderer_mixer_input_unittest.cc View 1 3 chunks +26 lines, -9 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
Guido Urdaneta
Hi, PTAL
4 years, 3 months ago (2016-09-21 16:15:33 UTC) #6
DaleCurtis
lgtm
4 years, 3 months ago (2016-09-21 16:54:31 UTC) #13
Guido Urdaneta
updated failing unit test. still looks good?
4 years, 3 months ago (2016-09-21 17:45:12 UTC) #15
DaleCurtis
lgtm
4 years, 3 months ago (2016-09-21 20:29:17 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359883002/100001
4 years, 3 months ago (2016-09-22 05:40:35 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 3 months ago (2016-09-22 05:45:37 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 05:47:58 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f36a74f8081e3830a9c9fb48854c1a831cf6086
Cr-Commit-Position: refs/heads/master@{#420269}

Powered by Google App Engine
This is Rietveld 408576698