third_party/WebKit/LayoutTests/fast/canvas/canvas-2d-clip-anti-aliasing.html - Issue 2359843003: Turning on clip anti-aliasing by default in Chrome.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-2d-clip-anti-aliasing.html

Issue 2359843003: Turning on clip anti-aliasing by default in Chrome. (Closed)

Patch Set: Addressing comments from patch set 3. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <canvas id="myCanvas" width="240" height="240" style="border:1px solid #d3d3d3;" ></canvas>

	6

	7 <script>

	8

	9 test(function() {

	10 var c = document.getElementById("myCanvas");

	11 var ctx = c.getContext("2d");

	12

	13 ctx.beginPath();

	14 ctx.moveTo(120, 20);

	15 ctx.lineTo(220, 120);

	16 ctx.lineTo(120, 220);

	17 ctx.lineTo(20, 120);

	18 ctx.lineTo(120, 20);

	19 ctx.closePath();

	20 ctx.clip();

	21

	22 ctx.lineWidth = 1;

	23 ctx.strokeStyle="#FF0000";

	24 ctx.stroke();

	25

	26 // When canvas clips are not anti-aliased, only the first two segments of

	27 // the diamond-shaped closed path are drawn on the canvas.

	28 // To check that canvas clip anti-aliasing works fine, we check the

	29 // junction of the third and fourth segments of the path.
	Justin Novosad 2016/09/22 19:15:18 You should check multiple points. you never know h You should check multiple points. you never know how this might regress in the future.
	30 var colorData = ctx.getImageData(20, 120, 1, 1).data;

	31 assert_equals(colorData[0], 255);

	32 assert_equals(colorData[1], 0);

	33 assert_equals(colorData[2], 0);

	34 assert_not_equals(colorData[3], 0);

	35

	36 }, 'canvas-2d-clip-anti-aliasing should not return any error');
	Justin Novosad 2016/09/22 19:15:18 The description you put here should describe what The description you put here should describe what is being tested. "Verifies that a stroke inside a clip of the same path displays correctly. Some sides of the shape may be clipped-out if stroking is anti-aliased but not clipping, or if clipping it is not properly aligned."
	37

	38 </script>

	39

	40

	41

OLD	NEW

« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/core/frame/Settings.in » ('j') | no next file with comments »