third_party/WebKit/Source/core/frame/Settings.in - Issue 2359843003: Turning on clip anti-aliasing by default in Chrome.

Side by Side Diff: third_party/WebKit/Source/core/frame/Settings.in

Issue 2359843003: Turning on clip anti-aliasing by default in Chrome. (Closed)

Patch Set: Adding the layout test. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« content/public/common/web_preferences.cc ('K') | « third_party/WebKit/LayoutTests/fast/canvas/canvas-2d-clip-anti-aliasing.html ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Defines properties which are available on the Settings object.	1 # Defines properties which are available on the Settings object.

2 #	2 #

3 # Please think carefully before adding a new Setting. Some questions to	3 # Please think carefully before adding a new Setting. Some questions to

4 # consider are:	4 # consider are:

5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things	5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things

6 # which we support either values of at runtime. Features are set at renderer	6 # which we support either values of at runtime. Features are set at renderer

7 # process startup and are never changed. Features also tend to be set to a	7 # process startup and are never changed. Features also tend to be set to a

8 # value based on the platform or the stability of the code in question, where	8 # value based on the platform or the stability of the code in question, where

9 # as settings both codepaths need to be stable.	9 # as settings both codepaths need to be stable.

10 # - How will you ensure test coverage of all relevant values of your setting?	10 # - How will you ensure test coverage of all relevant values of your setting?

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
80	80

81 xssAuditorEnabled initial=false	81 xssAuditorEnabled initial=false

82	82

83 preferCompositingToLCDTextEnabled initial=false, invalidate=AcceleratedCompositi ng	83 preferCompositingToLCDTextEnabled initial=false, invalidate=AcceleratedCompositi ng

84	84

85 # 3D canvas (WebGL) support.	85 # 3D canvas (WebGL) support.

86 webGLEnabled initial=false	86 webGLEnabled initial=false

87	87

88 webGLErrorsToConsoleEnabled initial=true	88 webGLErrorsToConsoleEnabled initial=true

89 antialiased2dCanvasEnabled initial=true	89 antialiased2dCanvasEnabled initial=true

90 antialiasedClips2dCanvasEnabled initial=false	90 antialiasedClips2dCanvasDisabled initial=false
	Justin Novosad 2016/09/21 21:27:02 This is not correct. We do not do inverted logic f This is not correct. We do not do inverted logic for flags. Keep 'Enabled' like before, just change the default to true. xlai (Olivia) 2016/09/22 14:11:34 I assume you want to enforce antialiasedClips to b Show quoted text On 2016/09/21 21:27:02, Justin Novosad wrote: > This is not correct. We do not do inverted logic for flags. Keep 'Enabled' like > before, just change the default to true. I assume you want to enforce antialiasedClips to be enabled by default. According to the previous comment, we want to keep the antialiazedClips2dCanvasEnabled flag name unchanged. Then if we set this flag to be true, what happened if users append this flag in command line? There would be no effect (you're turning on something that is already on by default). I checked chrome://flags and couldn't find this flag available to be modified in GUI. It seems that it can only be passed on in command line.
91 accelerated2dCanvasMSAASampleCount type=int, initial=0	91 accelerated2dCanvasMSAASampleCount type=int, initial=0

92	92

93 hyperlinkAuditingEnabled initial=false	93 hyperlinkAuditingEnabled initial=false

94 allowRunningOfInsecureContent initial=true	94 allowRunningOfInsecureContent initial=true

95	95

96 mediaControlsOverlayPlayButtonEnabled initial=false	96 mediaControlsOverlayPlayButtonEnabled initial=false

97 mediaPlaybackRequiresUserGesture initial=false	97 mediaPlaybackRequiresUserGesture initial=false

98	98

99 presentationRequiresUserGesture initial=true	99 presentationRequiresUserGesture initial=true

100	100

(...skipping 311 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
412 # Variant of the ParseHTMLOnMainThread experiment. This is designed to coalesce	412 # Variant of the ParseHTMLOnMainThread experiment. This is designed to coalesce

413 # TokenizedChunks when the experiment is running in threaded mode.	413 # TokenizedChunks when the experiment is running in threaded mode.

414 parseHTMLOnMainThreadCoalesceChunks initial=false	414 parseHTMLOnMainThreadCoalesceChunks initial=false

415	415

416 # Whether the CSSPreloadScanner is used for externally CSS preloads. NoPreload	416 # Whether the CSSPreloadScanner is used for externally CSS preloads. NoPreload

417 # indicates that the scanner will be used, but no preloads issued.	417 # indicates that the scanner will be used, but no preloads issued.

418 cssExternalScannerNoPreload initial=false	418 cssExternalScannerNoPreload initial=false

419 cssExternalScannerPreload initial=false	419 cssExternalScannerPreload initial=false

420	420

421 browserSideNavigationEnabled initial=false	421 browserSideNavigationEnabled initial=false

OLD	NEW