Add support for setting password value gated on user's gesture in a page

Source/web/tests/WebViewTest.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1114 matching lines @@
 
     // Just make sure we don't hit any asserts.
     webViewImpl->handleInputEvent(event);
 }
 
 class MockAutofillClient : public WebAutofillClient {
 public:
     MockAutofillClient()
         : m_ignoreTextChanges(false)
         , m_textChangesWhileIgnored(0)
-        , m_textChangesWhileNotIgnored(0) { }
+        , m_textChangesWhileNotIgnored(0)
+        , m_userGestureNotificationsCount(0) { }
 
     virtual ~MockAutofillClient() { }
 
     virtual void setIgnoreTextChanges(bool ignore) OVERRIDE { m_ignoreTextChanges = ignore; }
     virtual void textFieldDidChange(const WebFormControlElement&) OVERRIDE
     {
         if (m_ignoreTextChanges)
             ++m_textChangesWhileIgnored;
         else
             ++m_textChangesWhileNotIgnored;
     }
+    virtual void firstUserGestureObserved() { ++m_userGestureNotificationsCount; }

[tkent, 2014/04/16 02:09:12]

nit: add OVERRIDE

[vabr (Chromium), 2014/04/16 07:22:00]

Done.

 
     void clearChangeCounts()
     {
         m_textChangesWhileIgnored = 0;
         m_textChangesWhileNotIgnored = 0;
     }
 
     int textChangesWhileIgnored() { return m_textChangesWhileIgnored; }
     int textChangesWhileNotIgnored() { return m_textChangesWhileNotIgnored; }
+    int getUserGestureNotificationsCount() { return m_userGestureNotificationsCount; }
 
 private:
     bool m_ignoreTextChanges;
     int m_textChangesWhileIgnored;
     int m_textChangesWhileNotIgnored;
+    int m_userGestureNotificationsCount;
 };
 
 
 TEST_F(WebViewTest, LosingFocusDoesNotTriggerAutofillTextChange)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("input_field_populated.html"));
     MockAutofillClient client;
     WebView* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "input_field_populated.html");
     webView->setAutofillClient(&client);
     webView->setInitialFocus(false);
@@ skipping 693 matching lines @@
     // (B.3) Unfocused and value is changed by script.
     client.reset();
     EXPECT_FALSE(client.textIsUpdated());
     document->setFocusedElement(nullptr);
     webViewImpl->setFocus(false);
     EXPECT_NE(document->focusedElement(), static_cast<WebCore::Element*>(textAreaElement));
     inputElement->setValue("testB3");
     EXPECT_FALSE(client.textIsUpdated());
 }
 
+// Check that the WebAutofillClient is correctly notified about first user
+// gestures after load, following various input events.
+TEST_F(WebViewTest, FirstUserGestureObservedKeyEvent)
+{
+    URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("form.html"));
+    MockAutofillClient client;
+    WebView* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "form.html", true);
+    webView->setAutofillClient(&client);
+    webView->setInitialFocus(false);
+
+    EXPECT_EQ(0, client.getUserGestureNotificationsCount());
+
+    WebKeyboardEvent keyEvent;
+    keyEvent.windowsKeyCode = WebCore::VKEY_SPACE;
+    keyEvent.type = WebInputEvent::RawKeyDown;
+    keyEvent.setKeyIdentifierFromWindowsKeyCode();
+    webView->handleInputEvent(keyEvent);
+    keyEvent.type = WebInputEvent::KeyUp;
+    webView->handleInputEvent(keyEvent);
+
+    EXPECT_EQ(1, client.getUserGestureNotificationsCount());
+    webView->setAutofillClient(0);
+}
+
+TEST_F(WebViewTest, FirstUserGestureObservedMouseEvent)
+{
+    URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("form.html"));
+    MockAutofillClient client;
+    WebView* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "form.html", true);
+    webView->setAutofillClient(&client);
+    webView->setInitialFocus(false);
+
+    EXPECT_EQ(0, client.getUserGestureNotificationsCount());
+
+    WebMouseEvent mouseEvent;
+    mouseEvent.button = WebMouseEvent::ButtonLeft;
+    mouseEvent.x = 1;
+    mouseEvent.y = 1;
+    mouseEvent.clickCount = 1;
+    mouseEvent.type = WebInputEvent::MouseDown;
+    webView->handleInputEvent(mouseEvent);
+    mouseEvent.type = WebInputEvent::MouseUp;
+    webView->handleInputEvent(mouseEvent);
+
+    EXPECT_EQ(1, client.getUserGestureNotificationsCount());
+    webView->setAutofillClient(0);
+}
+
+TEST_F(WebViewTest, FirstUserGestureObservedGestureTap)
+{
+    URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("longpress_selection.html"));
+    MockAutofillClient client;
+    WebView* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "longpress_selection.html", true);
+    webView->setAutofillClient(&client);
+    webView->setInitialFocus(false);
+
+    EXPECT_EQ(0, client.getUserGestureNotificationsCount());
+
+    EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureTap, WebString::fromUTF8("target")));
+
+    EXPECT_EQ(1, client.getUserGestureNotificationsCount());
+    webView->setAutofillClient(0);
+}
+
 } // namespace