SkRecord bug fixes

SkRecord bug fixes

Optional arguments to SkCanvas calls leaked refs (but not memory) because we
didn't destruct the optional objects (really, just SkPaint: other optional args
are all POD).  This adds Optional and PODArray, where Optional makes sure to
call the destructor.

I overlooked that SkPictureRecord really does call paint.computeFastBounds().
Do the same in SkRecordDraw.

BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14197

[tomhudson, 2014-04-15 13:41:36]

LGTM modulo comment nits.

https://codereview.chromium.org/235983015/diff/20001/src/record/SkRecordDraw.cpp
File src/record/SkRecordDraw.cpp (right):

https://codereview.chromium.org/235983015/diff/20001/src/record/SkRecordDraw....
src/record/SkRecordDraw.cpp:79: // We need to call computeFastBounds() to adjust
the text bounds for paint effects.
This edited comment really belongs below with adjusted, rather than up here with
the early exit, right?

https://codereview.chromium.org/235983015/diff/20001/src/record/SkRecordDraw....
src/record/SkRecordDraw.cpp:92: // Let the paint have its say of any extra
efect.  0,1 for left,right makes the rect non-empty.
spelling: effect.
Also, meaning of the entire comment isn't clear.

[mtklein, 2014-04-15 13:58:43]

How's this?

[tomhudson, 2014-04-15 14:07:59]

Thanks.

[mtklein, 2014-04-15 14:09:09]

lgtm

[commit-bot: I haz the power, 2014-04-15 14:09:26]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/235983015/40001

[commit-bot: I haz the power, 2014-04-15 14:27:17]

Change committed as 14197