GN Windows build fixes

base/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 
 component("base") {
   sources = [
     "third_party/dmg_fp/dmg_fp.h",
     "third_party/dmg_fp/g_fmt.cc",
@@ skipping 770 matching lines @@
     linux_configs = [
       "//build/config/linux:glib",
     ]
     if (toolkit_uses_gtk) {
       linux_configs += [ "//build/config/linux:gtk" ]
     }
     if (use_x11) {
       linux_configs += [
         "//build/config/linux:x11",
       ]
-    } else {
-      # On non-Linux platforms, the X11 files will already have been filtered
-      # out using the sources assignment filter.
-      sources -= [
-        "message_loop/message_pump_x11.cc",
-        "message_loop/message_pump_x11.h",
-      ]
     }
 
     configs += linux_configs
     all_dependent_configs = linux_configs
 
     if (!is_android) {
       # These dependencies are not required on Android, and in the case
       # of xdg_mime must be excluded due to licensing restrictions.
       deps += [
         "//base/third_party/symbolize",
         "//base/third_party/xdg_mime",
         "//base/third_party/xdg_user_dirs",
       ]
     }
   } else {
     # Non-Linux.
     sources -= [
       "nix/mime_util_xdg.cc",
       "nix/mime_util_xdg.h",
       "nix/xdg_util.cc",
       "nix/xdg_util.h",
     ]
   }
 
+  if (!use_x11) {

[scottmg, 2014/04/11 21:43:26]

why is this better?

[brettw, 2014/04/11 23:05:00]

Before this was only done on Linux when we weren't using X11 (since otherwise on
Linux it was always removed and this code would fail since the items weren't
found). Now its removed any time we aren't using X11.

[scottmg, 2014/04/11 23:12:31]

Oops, sorry, can't read.

+    sources -= [
+      "message_loop/message_pump_x11.cc",
+      "message_loop/message_pump_x11.h",
+    ]
+  }
+
   if (!use_glib) {
     sources -= [
       "message_loop/message_pump_glib.cc",
       "message_loop/message_pump_glib.h",
     ]
   }
   if (!toolkit_uses_gtk) {
     sources -= [
       "message_loop/message_pump_gtk.cc",
       "message_loop/message_pump_gtk.h",
@@ skipping 62 matching lines @@
   #    # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
   #    'msvs_disabled_warnings': [
   #      4267,
   #    ],
   #  }],
   #],
   #'variables': {
   #  'optimize': 'max',
   #},
 }